feat(sandboxes): server-side ordering and state filter for sandbox list#475
Draft
huv1k wants to merge 1 commit into
Draft
feat(sandboxes): server-side ordering and state filter for sandbox list#475huv1k wants to merge 1 commit into
huv1k wants to merge 1 commit into
Conversation
Switch the new sandbox list (list2) to server-side ordering and add a running/paused state filter, both pushed to GET /v2/sandboxes so they apply across the whole dataset instead of only the loaded pages. - Thread an order (asc|desc) param derived from the startedAt sort header into the paginated query; the table now uses manualSorting and refetches on toggle. - Add a State filter (running/paused) to the Filters dropdown, rendered with the existing status badges; selecting one sends state=... to the API. - Wire states/order through the tRPC router and sandboxes repository; regenerate infra types for the new order param.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the new sandbox list (list2) ordering to the server and adds a running/paused state filter, both pushed to
GET /v2/sandboxesso they apply across the whole dataset, not just the pages already loaded into the infinite-scroll list.Changes
order(asc/desc) from the Started At sort header and pass it intolistSandboxesPaginated. The table now usesmanualSortingand refetches from page 1 on toggle. Defaultdescmatches the SSR prefetch key.Badges to match the Figma design. Both selected = no filter (server default); selecting one sendsstate=.... Always keeps at least one selected.order/statesthrough the tRPC router and sandboxes repository; included state in the empty-state and scroll-reset logic; regenerated infra types for the neworderparam.Notes
orderparam — companion PR: feat(api): add sort order to GET /v2/sandboxes infra#3107.tscandbiomeclean on changed files.Test
Open list2 → toggle Started At (watch Network:
order=asc|desc), and Filters → State → Running/Paused (state=...). Verify ordering/filtering hold beyond the first 50 rows.