Bundle team app keys and fix ls error handling#241
Merged
Conversation
- Use official bundled app keys for team-access and team-manage logins, so app-key override is optional when defaults are available - Simplify app-key prompting to only ask when the effective key is empty - Fix ls error handling to use errors.As with correct Dropbox API error types: ListFolderAPIError for list-folder and ListRevisionsAPIError for list-revisions - Ensure ls short output ends with a newline for partial rows - Unexport setPathDisplayAsDeleted because it is package-local - Use pointer receivers on storedCredential methods consistently - Silence errcheck warnings on fmt.Fprint calls to tabwriter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lscommand: was usingListRevisionsAPIErrorfor list-folder errors, now correctly usesListFolderAPIErrorwitherrors.AsfinishListOutputhelper, unexportSetPathDisplayAsDeleted, use pointer receivers consistently onstoredCredentialTest plan
dbxcli login team-accessuses bundled key without promptingdbxcli login team-manageuses bundled key without promptingdbxcli ls /path/to/fileworks correctly (single file listing)dbxcli ls --include-deleted /pathhandles not_folder and not_file errorsgo test ./...)