[msbuild] Only run _CreateInstaller target for desktop platforms. Fixes #19790#25825
[msbuild] Only run _CreateInstaller target for desktop platforms. Fixes #19790#25825rolfbjarne wants to merge 1 commit into
Conversation
The _CreateInstaller target creates a .pkg installer, which is only useful for desktop platforms (macOS and Mac Catalyst). Previously, setting CreatePackage=true for an iOS or tvOS project would attempt to create a .pkg, which is useless and would fail if /usr/bin/productbuild is not available. Add a 'SdkIsDesktop' == 'true' condition to the target so it only runs for macOS and Mac Catalyst projects. Fixes #19790 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #8281934] Build passed (Build packages) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #8281934] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #8281934] Build passed (Build macOS tests) ✅Pipeline on Agent |
🔥 [CI Build #8281934] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 2 tests failed, 205 tests passed. Failures❌ fsharp tests2 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
2 participants
The
_CreateInstallertarget creates a.pkginstaller package, which is onlymeaningful for desktop platforms (macOS and Mac Catalyst). Previously, setting
CreatePackage=truefor an iOS or tvOS project would attempt to create a.pkg,which is useless and fails if
/usr/bin/productbuildis not available.Add a
$(SdkIsDesktop) == 'true'condition to the_CreateInstallertarget soit only executes for macOS and Mac Catalyst projects.
Fixes #19790
🤖 Pull request created by Copilot