[DRAFT] [net11.0] [msbuild/tools] Move post-trimming custom trimmer steps to a post-ILLink MSBuild task.#25803
Draft
rolfbjarne wants to merge 51 commits into
Draft
[DRAFT] [net11.0] [msbuild/tools] Move post-trimming custom trimmer steps to a post-ILLink MSBuild task.#25803rolfbjarne wants to merge 51 commits into
rolfbjarne wants to merge 51 commits into
Conversation
…MENT (#25747) Remove REQUEST_CHANGES from allowed review events and update instructions in both the workflow file and SKILL.md to always submit COMMENT reviews. The supersede-older-reviews setting was already enabled to hide previous review comments as outdated. 🤖 Pull request created by Copilot --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Improve XML documentation for the `SKCloudServiceSetupOptions` type: - Remove "To be added." placeholder entries for `<value>` and `<remarks>` - Add meaningful `<value>` description for the `Action` property 🤖 Pull request created by Copilot --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ld properties. Fixes #24848 (#25715) Adds unified MSBuild properties to control `dotnet run` behavior across all Apple platforms (iOS, tvOS, macOS, Mac Catalyst): - `WaitForExit`: whether `dotnet run` waits for the app to exit before returning. - `StandardOutputPath`: redirect app stdout to a file. - `StandardErrorPath`: redirect app stderr to a file. These properties work for both mobile (simulator/device via mlaunch) and desktop (macOS/Mac Catalyst via `open`). Existing platform-specific properties (`_MlaunchWaitForExit`, `_MlaunchStandardOutputPath`, `_MlaunchStandardErrorPath` for mobile, and `OpenWaitForExit` for desktop) continue to work, but the new properties take precedence when set. Unit tests verify that the new properties flow correctly into the underlying arguments, and that they properly override the old properties when both are set. Fixes #24848 🤖 Pull request created by Copilot --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
#25732) They may not exist on the Mac, if they were produced locally on Windows.
…20260621053538722 to main (#25757) LEGO: Pull request from lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20260621053538722 to main with localized lcls
…20718. (#25714) The "New Project" wizard in Visual Studio shows raw camelCase identifiers ("bundleId", "minOSVersion", "deviceFamily") for template parameter labels because the symbols lack a `displayName` property. The .NET template engine uses `displayName` for the UI label, falling back to the symbol identifier when it is missing. This PR adds `displayName` to every symbol (`bundleId` -> "Bundle ID", `minOSVersion` -> "Minimum OS version", `deviceFamily` -> "Device family", `extensionClassName` -> "Extension class name") and to `deviceFamily` choice values ("Universal", "iPhone", "iPad") across all 12 template.json files (iOS, macOS, tvOS, Mac Catalyst -- C#, F#, VB variants). The corresponding `symbols/*/displayName` localization keys are added to all 14 locale templatestrings files with English placeholder text. The localization pipeline (OneLocBuild) will provide actual translations. Hopefully fixes #20718 🤖 Pull request created by Copilot --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This pull request updates the following dependencies ## From https://github.com/dotnet/xharness - **Subscription**: [02e03784-16b3-4ced-b02a-3715797fc7da](https://maestro.dot.net/subscriptions?search=02e03784-16b3-4ced-b02a-3715797fc7da) - **Build**: [20260619.2](https://dev.azure.com/dnceng/internal/_build/results?buildId=3003827) ([319386](https://maestro.dot.net/channel/2/github:dotnet:xharness/build/319386)) - **Date Produced**: June 19, 2026 9:42:47 AM UTC - **Commit**: [a0534aec8f776d258392f0266cbdb9cc97e1dd98](dotnet/xharness@a0534ae) - **Branch**: [main](https://github.com/dotnet/xharness/tree/main) - **Dependency Updates**: - From [11.0.0-prerelease.26316.1 to 11.0.0-prerelease.26319.2][1] - Microsoft.DotNet.XHarness.iOS.Shared [1]: dotnet/xharness@8d6fae7...a0534ae
ARM64 is the default everywhere now, and it's the only architecture we'll run on anyways, so there's no need to condition anything on arm64 being available. This also makes it possible to remove some redundant test configurations. Additionally, make 'supports_interpreter' conditioned on 'supports_mono', since that's really what it is.
…PRs (#25761) Two improvements to the code radiator workflow: ## Milestone-based filtering After identifying candidate branches, the workflow now checks whether each branch has a corresponding closed milestone. If the milestone is closed, the branch is skipped. Milestone mapping: | Branch pattern | Milestone name | |------------------|----------------------------------------------| | `net<major>.0` | `.NET <major>` (e.g., `net10.0` → `.NET 10`) | | `xcode<version>` | `xcode<version>` (direct match) | ## Close stale PRs superseded by manual merges When an existing workflow-created PR is found, the workflow now checks if someone manually merged `main` into the target branch after the PR was created. If so, the existing PR is closed with a comment and a fresh one is created from scratch. This handles cases like #25728 where a manual merge was done after the automated PR was created, making the automated PR stale. 🤖 Pull request created by Copilot --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…on. Fixes #20717 (#25717) The `templatestrings.en.json` files in `dotnet/Templates/` were not included in the `LocProject.json` configuration, which meant OneLocBuild never picked them up for translation. This PR replaces the static `LocProject.json.in` template with a `generate-loc-project.sh` script that dynamically discovers all `templatestrings.en.json` files and includes them in the generated `LocProject.json`. This also fixes a duplicate entry for `Microsoft.Macios.Generator/Resources.resx` that was in the original `.in` file. Hopefully fixes #20717 🤖 Pull request created by Copilot --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…5765) The dotnet/macios secret-audit report flags every secret name that appears in a compiled agentic workflow, including the "magic" fallback secrets that gh-aw emits as the tail of its token-resolution chains (`GH_AW_GITHUB_TOKEN` and `GH_AW_GITHUB_MCP_SERVER_TOKEN`). Those names showed up in all three `*.lock.yml` files even though we never configure them, because gh-aw bakes the full fallback expression into every safe-output handler, into the GitHub MCP server wiring, and into the checkout "Fetch additional refs" step. Set explicit `github-token: ${{ secrets.GITHUB_TOKEN }}` overrides so the compiler short-circuits each fallback chain before it references the magic names: - `tools.github.github-token` → replaces the `GH_AW_GITHUB_MCP_SERVER_TOKEN` → `GH_AW_GITHUB_TOKEN` → `GITHUB_TOKEN` chain used by the GitHub MCP server container. - `safe-outputs.github-token` → replaces the `GH_AW_GITHUB_TOKEN` → `GITHUB_TOKEN` chain used by the safe-output handlers. - `checkout.github-token` (code-radiator only) → replaces the `GH_AW_GITHUB_MCP_SERVER_TOKEN` → `GH_AW_GITHUB_TOKEN` → `GITHUB_TOKEN` chain used by the "Fetch additional refs" step that `checkout.fetch: ["*"]` generates. `GITHUB_TOKEN` is sufficient to fetch refs from the same repository, so there is no functional change. `GH_AW_CI_TRIGGER_TOKEN` is intentionally left in place in code-radiator. Unlike the chains above it is **not** a magic fallback: it is the documented secret gh-aw uses to push an empty commit after `create-pull-request` / `push-to-pull-request-branch` so that CI runs on the auto-created merge PRs (pushes made with `GITHUB_TOKEN` do not trigger workflow runs — a GitHub Actions security feature). Overriding it with `GITHUB_TOKEN` would silently stop CI from triggering on those PRs. This branch also recompiles all three workflows with the locally installed gh-aw compiler (v0.79.8), which refreshes the generated lock files, the `agentics-maintenance.yml` maintenance workflow, `actions-lock.json`, and the gh-aw dependabot ignore entry. After recompiling, the `# Secrets used:` block in each lock file lists only secrets that are actually configured: | Workflow | Secrets | |----------|---------| | `ci-postmortem.lock.yml` | `COPILOT_GITHUB_TOKEN`, `GITHUB_TOKEN` | | `code-radiator.lock.yml` | `COPILOT_GITHUB_TOKEN`, `GH_AW_CI_TRIGGER_TOKEN`, `GITHUB_TOKEN` | | `macios-reviewer.lock.yml` | `COPILOT_GITHUB_TOKEN`, `GITHUB_TOKEN` | `gh aw compile` reports 0 errors on all three workflows. Inspired by dotnet/android#11685 (commit `dbd72dd`). 🤖 Pull request created by Copilot --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Apple platform builds and publishes now expose their final outputs
through a shared `@(ApplicationArtifact)` MSBuild item group. This gives
custom targets, tooling, and CI a stable, structured way to discover the
produced `.app`, `.ipa`, `.pkg`, and `.xcarchive` outputs instead of
parsing individual scalar properties (`$(AppBundleDir)`,
`$(IpaPackagePath)`, `$(PkgPackagePath)`, `$(ArchiveDir)`, …). The item
group name is platform-neutral, leaving room for other SDKs to reuse the
same contract.
## What's exposed
- One `@(ApplicationArtifact)` item per final artifact, whose item
identity is the **absolute path** to the artifact.
- Well-known metadata on each item:
- `PackageFormat` — `app`, `ipa`, `pkg`, or `xcarchive`
- `IsDirectory` — `true` for `.app`/`.xcarchive`, `false` for
`.ipa`/`.pkg`
- `PlatformName` — `iOS`, `tvOS`, `macOS`, or `MacCatalyst`
- `BundleIdentifier` — the resolved app bundle identifier
- Collected automatically during a normal build: the app bundle after
`Codesign`, the IPA after `CreateIpa`, the PKG after `_CreateInstaller`,
and the Xcode archive after `Archive` — so artifacts gated by
`BuildIpa`, `CreatePackage`, or `ArchiveOnBuild` are surfaced when those
are enabled.
## How to query
`GetApplicationArtifacts` builds the project and returns
`@(ApplicationArtifact)`; `Publish` returns the same group (and enables
`BuildIpa`/`CreatePackage` as appropriate):
```
$ dotnet build MyApp.csproj -t:GetApplicationArtifacts -getItem:ApplicationArtifact
$ dotnet build MyApp.csproj -t:Publish -getItem:ApplicationArtifact
```
## Extensibility
- `GetApplicationArtifactsDependsOn` is a post-build extension point so
later SDK layers (for example .NET MAUI) can enrich the metadata on the
platform-created items, or add items for additional artifacts.
- `Build` is a hard-coded dependency of `GetApplicationArtifacts`,
outside the overridable property, so overwriting
`GetApplicationArtifactsDependsOn` can never skip platform artifact
population. Platform metadata stays limited to the four well-known
values above; extension targets own anything richer and should update
the platform-created items rather than duplicate them.
## Windows (Pair to Mac)
On Windows the `.ipa`/`.xcarchive` are produced on the paired Mac and
only copied back afterwards, so the collectors are anchored on the
public `CreateIpa`/`Archive` wrapper targets (which complete after the
copy-back) instead of the internal `_ZipIpa`/`_CoreArchive`. The archive
collector prefers the local `$(ArchiveDir)` and falls back to the
copied-back `$(ArchivePath)`. The `.app` stays on the Mac during a
remote build, so it is intentionally not surfaced there (guarded by
`IsRemoteBuild`); surfacing the Windows `.app` and the
`IsAppDistribution` IPA is left for a follow-up.
## App-extension fix
Adding a `Returns` attribute (on `GetApplicationArtifacts`) surfaced a
subtle MSBuild behavior: once any target in a `.targets` file uses
`Returns`, that file's other targets stop returning their `Outputs` to
`<MSBuild>` callers. That silently emptied the legacy
`GetAppExtensionBundlePath`/`BuildAndGetAppExtensionBundlePath` getters,
so app extensions were no longer embedded into their container app's
`PlugIns` folder. Both targets now declare `Returns` explicitly (equal
to their previous `Outputs`), restoring extension embedding while
keeping the new feature.
## Tests
- A dedicated `MySimpleAppWithArtifactMetadata` test project (rather
than mutating a shared one) exercises the
`GetApplicationArtifactsDependsOn` extension/override behavior so the
tests can run in parallel.
- `PostBuildTest` item-query tests for `.app`, `.ipa`, `.pkg`, and
`.xcarchive`, extension-added metadata, publish-target augmentation, an
overwritten `GetApplicationArtifactsDependsOn`, and the target
dependency graph — asserted both from the binlog and via `-getItem`.
- `[Category("RemoteWindows")]` tests validating that the `.ipa` and
`.xcarchive` are surfaced after Pair-to-Mac copy-back.
## Docs
- `docs/building-apps/build-items.md` — `@(ApplicationArtifact)` and its
metadata.
- `docs/building-apps/build-properties.md` —
`GetApplicationArtifactsDependsOn`.
- `docs/building-apps/build-targets.md` — the `GetApplicationArtifacts`
contract and `-getItem` query examples.
## Validation
- `xmllint --noout msbuild/Xamarin.Shared/Xamarin.Shared.targets
msbuild/Xamarin.Shared/Xamarin.iOS.Common.targets`
- `git diff --check`
- Built the product (`make all install`) and ran the
`@(ApplicationArtifact)` query tests and the app-extension build tests
for iOS/tvOS/macOS: artifacts are populated with absolute paths and
correct metadata, and app extensions are embedded into their container
app.
- The RemoteWindows IPA/archive tests run on the Windows CI leg.
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Alex Soto <alex@soto.dev>
… 5f63985fe82894604956e653d43c161ebbc1b576 to bace0c94c5ec24d81dc66d1adfb5ce44edb218e6 (#25766) Bumps [dotnet/arcade/.github/workflows/inter-branch-merge-base.yml](https://github.com/dotnet/arcade) from 5f63985fe82894604956e653d43c161ebbc1b576 to bace0c94c5ec24d81dc66d1adfb5ce44edb218e6. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…20260620053547244 to main (#25755) LEGO: Pull request from lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20260620053547244 to main with localized lcls
…20260620173520203 to main (#25756) LEGO: Pull request from lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20260620173520203 to main with localized lcls
This pull request updates the following dependencies ## From https://github.com/dotnet/dotnet - **Subscription**: [da09b56a-0fb1-439a-b894-def14d2ec0a4](https://maestro.dot.net/subscriptions?search=da09b56a-0fb1-439a-b894-def14d2ec0a4) - **Build**: [20260619.2](https://dev.azure.com/dnceng/internal/_build/results?buildId=3004070) ([319494](https://maestro.dot.net/channel/10307/github:dotnet:dotnet/build/319494)) - **Date Produced**: June 19, 2026 11:16:21 PM UTC - **Commit**: [9ae5b4b15619dd34a8086b2d511937505683a8c7](dotnet/dotnet@9ae5b4b) - **Branch**: [release/10.0.4xx](https://github.com/dotnet/dotnet/tree/release/10.0.4xx) - **Dependency Updates**: - From [10.0.0-beta.26318.103 to 10.0.0-beta.26319.102][1] - Microsoft.DotNet.Arcade.Sdk - Microsoft.DotNet.Build.Tasks.Feed - Microsoft.DotNet.SharedFramework.Sdk - From [10.0.400-preview.0.26318.103 to 10.0.400-preview.0.26319.102][1] - Microsoft.NET.Sdk - From [10.0.400-preview.26318.103 to 10.0.400-preview.26319.102][1] - Microsoft.TemplateEngine.Authoring.Tasks [1]: dotnet/dotnet@e312f47...9ae5b4b
Create separate steps for a few tasks. There should be no behavioral difference. --------- Co-authored-by: Rolf Bjarne Kvinge <rokvin@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…20260621175222065 to main (#25758) LEGO: Pull request from lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20260621175222065 to main with localized lcls
Improve XML documentation for the `StoreProductParameters` type: - Replace "To be added." placeholder entries with meaningful `<value>` descriptions - Improve `## ` text for `AffiliateToken` and `CampaignToken` properties - Remove empty `<remarks>` nodes 🤖 Pull request created by Copilot --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…est into one (#25770) The two [Category("RemoteWindows")] tests each triggered a full (slow) remote build to the paired Mac. Merge them into a single build that sets both BuildIpa=true and ArchiveOnBuild=true, so the Mac builds the app once instead of twice while still verifying that both the .ipa and the .xcarchive are surfaced in @(ApplicationArtifact). Fixes #25769 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The 'RunCommand' property is supposed to be the path to a single executable, and as such should not be quoted. See: dotnet/sdk#54917 (comment)
The `assembly-preparer.csproj` builds for two target frameworks (`netstandard2.0` and `net10.0`) in parallel. Both TFMs invoke `make generated-files` concurrently via a `BeforeTargets="CoreCompile"` target. Each `make` invocation triggers a rebuild of `assembly-preparer.csproj.inc` (via the pattern rule in `mk/rules.mk`), which runs `create-makefile-fragment.sh`. Two concurrent instances of this script share the same intermediate files (`.inputs`), causing one to corrupt or delete files the other needs. This results in a corrupt `.inc` file and a `*** missing separator` make error. The fix wraps the `-include assembly-preparer.csproj.inc` in an `ifneq ($(MAKECMDGOALS),generated-files)` guard, so the `.inc` file is not rebuilt when the target is `generated-files` -- since it is not needed for that target anyway. 🤖 Pull request created by Copilot --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This pull request updates the following dependencies ## From https://github.com/dotnet/dotnet - **Subscription**: [da09b56a-0fb1-439a-b894-def14d2ec0a4](https://maestro.dot.net/subscriptions?search=da09b56a-0fb1-439a-b894-def14d2ec0a4) - **Build**: [20260622.2](https://dev.azure.com/dnceng/internal/_build/results?buildId=3005481) ([319674](https://maestro.dot.net/channel/10307/github:dotnet:dotnet/build/319674)) - **Date Produced**: June 22, 2026 2:20:53 PM UTC - **Commit**: [0cf89a94a121c7e768174ad0ed0cdb8ad3bbf8e7](dotnet/dotnet@0cf89a9) - **Branch**: [release/10.0.4xx](https://github.com/dotnet/dotnet/tree/release/10.0.4xx) - **Dependency Updates**: - From [10.0.0-beta.26319.102 to 10.0.0-beta.26322.102][1] - Microsoft.DotNet.Arcade.Sdk - Microsoft.DotNet.Build.Tasks.Feed - Microsoft.DotNet.SharedFramework.Sdk - From [10.0.400-preview.0.26319.102 to 10.0.400-preview.0.26322.102][1] - Microsoft.NET.Sdk - From [10.0.400-preview.26319.102 to 10.0.400-preview.26322.102][1] - Microsoft.TemplateEngine.Authoring.Tasks [1]: dotnet/dotnet@9ae5b4b...0cf89a9
…25771) This way it's easy to get the path to the binlog if the test build fails.
Improve XML documentation for the `SKReceiptProperties` type: - Replace 'To be added.' placeholders with meaningful descriptions - Fix `see cref` reference to `SKReceiptRefreshRequest` - Remove empty `<remarks>` nodes - Add proper documentation for constructors and properties 🤖 Pull request created by Copilot --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…25749) Replace the Makefile-based test runner (`packaged-macos-tests.mk` + `run-with-timeout` + `mac-test-report-generator`) with a single C# script project (`scripts/run-packaged-macos-tests`) that: - Executes pre-built macOS and Mac Catalyst test apps with timeout and launch retry logic - Generates an HTML report with per-platform/architecture breakdown tables showing output links and [FAIL] lines inline - Generates TestSummary.md for GitHub PR comments - Handles ARM64/x64 architecture detection and skipping - Collects and links crash reports Simplifies `run_mac_tests.ps1` from ~235 lines to ~150 lines by delegating all test execution and reporting to the new C# tool. 🤖 Pull request created by Copilot --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ion. Fixes #25667. (#25699) Surface cancelled requests with an `TaskCanceledException` instead of a `TimeoutException`. This makes it easier for consumers to determine what happened. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> 🤖 Pull request created by Copilot Fixes: #25667 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Rolf Bjarne Kvinge <rokvin@microsoft.com>
Improve XML documentation for the `MPSkipIntervalCommand` type: - Replace 'To be added.' placeholders with meaningful descriptions - Fix `see cref` reference to use unqualified `MPRemoteCommandCenter` - Remove empty `<remarks>` nodes - Add proper documentation for the `PreferredIntervals` property 🤖 Pull request created by Copilot --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…raryDir property.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The PrepareAssemblies PostProcess pass modifies the (post-trimmed) assemblies, so those modifications must end up in the AOT/R2R-compiled output. For CoreCLR the ReadyToRun compilation runs inside 'ComputeFilesToPublish' (via 'CreateReadyToRunImages'), which happened *before* '_PostprocessAssemblies' (hooked on '_ComputeStripAssemblyIL'/'_LoadLinkerOutput'). As a result crossgen ran first and stubbed the method IL bodies to 'throw null' (the real code lives in the R2R native image), and then '_PostprocessAssemblies' rewrote those assemblies with Cecil, discarding the native code but keeping the stubs. At runtime the '<Module>' cctor (managed-static registration) executed the stub and threw a NullReferenceException, surfacing at startup as 'xamarin_bridge_call_runtime_initialize: failed to create delegate' / TypeLoadException. Hook '_PrepareForReadyToRunCompilation' (which computes the list of assemblies to crossgen) so the post-processed assemblies are the ones that get compiled. The existing '_ComputeStripAssemblyIL'/'_LoadLinkerOutput' hooks are kept for Mono, where the AOT compiler runs later (in '_CompileNativeExecutable'). Fixes 'make clean build run-bare -C "tests/linker/dont link/dotnet/MacCatalyst" TEST_VARIATION=prepare-assemblies|release|coreclr CONFIG=Release'. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
And disable it for CI. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Rolf Bjarne Kvinge <rokvin@microsoft.com>
…e condition) (#25797) Run 'dotnet --info' once right after downloading the .NET SDK to complete the first-time NuGet migrations logic. This avoids the race condition where multiple parallel dotnet processes attempt the first-time setup simultaneously, causing 'The system cannot open the device or file specified' errors. The workaround only runs in CI (when the ACES environment variable is set). Ref: dotnet/runtime#91987 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Rolf Bjarne Kvinge <rokvin@microsoft.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ng out-of-root libraries. The skip path indexed into the 'processes' List<Task> with the loop index, but that list is populated incrementally via Add (), so it's empty at that point and indexing throws ArgumentOutOfRangeException. Just continue instead, and drop the now-dead null filter on the reidentified output (which never contains nulls). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…raryDir property.
This comment has been minimized.
This comment has been minimized.
Collaborator
🔥 [PR Build #b3b4055] Build failed (Build macOS tests) 🔥Build failed for the job 'Build macOS tests' (with job status 'Failed') Pipeline on Agent |
Collaborator
✅ [PR Build #b3b4055] Build passed (Build packages) ✅Pipeline on Agent |
Collaborator
✅ [PR Build #b3b4055] Build passed (Detect API changes) ✅Pipeline on Agent |
Collaborator
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
Collaborator
🔥 [CI Build #b3b4055] Test results 🔥Test results❌ Tests failed on VSTS: test results 3 tests crashed, 3 tests failed, 190 tests passed. Failures❌ dotnettests tests (iOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (tvOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ msbuild tests1 tests failed, 1 tests passed.Failed tests
Html Report (VSDrops) Download ❌ Tests on macOS Sonoma (14) tests🔥 Failed catastrophically on VSTS: test results - mac_sonoma (no summary found). Html Report (VSDrops) Download ❌ Tests on macOS Sequoia (15) tests🔥 Failed catastrophically on VSTS: test results - mac_sequoia (no summary found). Html Report (VSDrops) Download ❌ Tests on macOS Tahoe (26) tests🔥 Failed catastrophically on VSTS: test results - mac_tahoe (no summary found). Html Report (VSDrops) Download Successes✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS testsLinux Build VerificationPipeline on Agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is only to get CI results, no need to review.