[msbuild] Resolve Content and BundleResource items using the main project's location. Fixes 23898. by rolfbjarne · Pull Request #25713 · dotnet/macios

rolfbjarne · 2026-06-17T14:24:39Z

Always compute the LogicalName for Content and BundleResource items relative to the project file (LocalMSBuildProjectFullPath) instead of the defining project file (LocalDefiningProjectFullPath). This fixes the issue where SDKs (like the Razor SDK) that add Content items from a directory far from the project would produce nonsensical paths like '../../../../../src/MyProject/file.png' that get rejected.

Fixes #23898

🤖 Pull request created by Copilot

Add a test that reproduces the issue where Content/BundleResource items defined by an SDK (like the Razor SDK) have their LogicalName computed relative to the SDK directory instead of the project directory, resulting in paths like '../../../../../src/MyProject/file.png' that get rejected. This test currently fails, demonstrating the bug described in #23898. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…s location. Fixes #23898. Always compute the LogicalName for Content and BundleResource items relative to the project file (LocalMSBuildProjectFullPath) instead of the defining project file (LocalDefiningProjectFullPath). This fixes the issue where SDKs (like the Razor SDK) that add Content items from a directory far from the project would produce nonsensical paths like '../../../../../src/MyProject/file.png' that get rejected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…10/11, opt-out for .NET 12+ Add a new MSBuild property ResolveResourceItemsRelativeToProject that controls whether Content and BundleResource items have their LogicalName computed relative to the project file (new behavior) or the defining project file (legacy behavior). - .NET 10 and .NET 11: defaults to false (opt-in) - .NET 12+: defaults to true (opt-out) The property is passed through a new IHasResolveResourceItemsRelativeToProject interface so that GetVirtualProjectPath can check the flag without changing its generic constraints. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ode paths Test with ResolveResourceItemsRelativeToProject=true (.NET 12+ default) and ResolveResourceItemsRelativeToProject=false (.NET 10/11 default) to ensure both the fixed and legacy behaviors are covered. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…test

vs-mobiletools-engineering-service2 · 2026-06-25T10:55:01Z

✅ [PR Build #824350c] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 824350c354e4259148aab2c04a6560f90894d60c [PR build]

vs-mobiletools-engineering-service2 · 2026-06-25T10:58:22Z

✅ [PR Build #824350c] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 824350c354e4259148aab2c04a6560f90894d60c [PR build]

vs-mobiletools-engineering-service2 · 2026-06-25T11:06:58Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 824350c354e4259148aab2c04a6560f90894d60c [PR build]

vs-mobiletools-engineering-service2 · 2026-06-25T11:14:09Z

🔥 [PR Build #824350c] Build failed (Build macOS tests) 🔥

Build failed for the job 'Build macOS tests' (with job status 'Failed')

Pipeline on Agent
Hash: 824350c354e4259148aab2c04a6560f90894d60c [PR build]

vs-mobiletools-engineering-service2 · 2026-06-25T12:52:29Z

🔥 [CI Build #824350c] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

5 tests crashed, 35 tests failed, 147 tests passed.

Failures

❌ linker tests (iOS)

15 tests failed, 0 tests passed.

Failed tests

dont link/iOS - simulator/Debug: LaunchTimedOut
dont link/iOS - simulator/Release: LaunchTimedOut
dont link/iOS - simulator/Debug (PrepareAssemblies, MonoVM, Dynamic Registrar): LaunchTimedOut
dont link/iOS - simulator/Debug (PrepareAssemblies, MonoVM, Managed Static Registrar): LaunchTimedOut
dont link/iOS - simulator/Release (PrepareAssemblies, MonoVM, Dynamic Registrar): LaunchTimedOut
dont link/iOS - simulator/Release (PrepareAssemblies, MonoVM, Managed Static Registrar): LaunchTimedOut
link sdk/iOS - simulator/Debug: LaunchTimedOut
link sdk/iOS - simulator/Release: LaunchTimedOut
link all/iOS - simulator/Debug: LaunchTimedOut
link all/iOS - simulator/Release: LaunchTimedOut
link all/iOS - simulator/Debug (don't bundle original resources): LaunchTimedOut
trimmode copy/iOS - simulator/Debug: LaunchTimedOut
trimmode copy/iOS - simulator/Release: LaunchTimedOut
trimmode link/iOS - simulator/Debug: LaunchTimedOut
trimmode link/iOS - simulator/Release: LaunchTimedOut

Html Report (VSDrops) Download

❌ monotouch tests (iOS)

20 tests failed, 0 tests passed.

Failed tests

monotouch-test/iOS - simulator/Debug: LaunchTimedOut
monotouch-test/iOS - simulator/Release (link sdk): LaunchTimedOut
monotouch-test/iOS - simulator/Release (link all): LaunchTimedOut
monotouch-test/iOS - simulator/Debug (PrepareAssemblies): LaunchTimedOut
monotouch-test/iOS - simulator/Debug (LinkSdk): LaunchTimedOut
monotouch-test/iOS - simulator/Debug (static registrar): LaunchTimedOut
monotouch-test/iOS - simulator/Release (all optimizations): LaunchTimedOut
monotouch-test/iOS - simulator/Release (NativeAOT): LaunchTimedOut
monotouch-test/iOS - simulator/Release (trimmable static registrar, NativeAOT): LaunchTimedOut
monotouch-test/iOS - simulator/Debug (managed static registrar): LaunchTimedOut
monotouch-test/iOS - simulator/Release (managed static registrar, all optimizations): LaunchTimedOut
monotouch-test/iOS - simulator/Release (NativeAOT, x64): LaunchTimedOut
monotouch-test/iOS - simulator/Release (trimmable static registrar, NativeAOT, x64): LaunchTimedOut
monotouch-test/iOS - simulator/Debug (interpreter): LaunchTimedOut
monotouch-test/iOS - simulator/Release (interpreter): LaunchTimedOut
monotouch-test/iOS - simulator/Release (compat inline Class.GetHandle): LaunchTimedOut
monotouch-test/iOS - simulator/Release (strict inline Class.GetHandle): LaunchTimedOut
monotouch-test/iOS - simulator/Release (compat inline dlfcn): LaunchTimedOut
monotouch-test/iOS - simulator/Release (strict inline dlfcn, link sdk): LaunchTimedOut
monotouch-test/iOS - simulator/Release (NativeAOT, .NET 11 defaults): LaunchTimedOut

Html Report (VSDrops) Download

❌ Tests on macOS Monterey (12) tests

🔥 Failed catastrophically on VSTS: test results - mac_monterey (no summary found).

Html Report (VSDrops) Download

❌ Tests on macOS Ventura (13) tests

🔥 Failed catastrophically on VSTS: test results - mac_ventura (no summary found).

Html Report (VSDrops) Download

❌ Tests on macOS Sonoma (14) tests

🔥 Failed catastrophically on VSTS: test results - mac_sonoma (no summary found).

Html Report (VSDrops) Download

❌ Tests on macOS Sequoia (15) tests

🔥 Failed catastrophically on VSTS: test results - mac_sequoia (no summary found).

Html Report (VSDrops) Download

❌ Tests on macOS Tahoe (26) tests

🔥 Failed catastrophically on VSTS: test results - mac_tahoe (no summary found).

Html Report (VSDrops) Download

Successes

✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 21 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 19 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 20 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 20 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: 824350c354e4259148aab2c04a6560f90894d60c [PR build]

rolfbjarne added the copilot label Jun 17, 2026

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/rolf/issue-23898-test

526bba8

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/main' into dev/rolf/issue-23898-…

1efd75e

…test

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/rolf/issue-23898-test

824350c

This comment has been minimized.

Sign in to view

Uh oh!

Conversation

rolfbjarne commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 25, 2026

✅ [PR Build #824350c] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 25, 2026

✅ [PR Build #824350c] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 25, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 25, 2026

🔥 [PR Build #824350c] Build failed (Build macOS tests) 🔥

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 25, 2026

🔥 [CI Build #824350c] Test results 🔥

Test results

Failures

❌ linker tests (iOS)

Failed tests

❌ monotouch tests (iOS)

Failed tests

❌ Tests on macOS Monterey (12) tests

❌ Tests on macOS Ventura (13) tests

❌ Tests on macOS Sonoma (14) tests

❌ Tests on macOS Sequoia (15) tests

❌ Tests on macOS Tahoe (26) tests

Successes

macOS tests

Linux Build Verification

Uh oh!

Reviewers

Assignees

Labels

Projects

rolfbjarne commented Jun 17, 2026 •

edited

Loading