Static pages#9
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #9 +/- ##
=============================================
+ Coverage 23.32% 23.48% +0.16%
- Complexity 174 175 +1
=============================================
Files 43 43
Lines 759 775 +16
=============================================
+ Hits 177 182 +5
- Misses 582 593 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alexmerlin
left a comment
alexmerlin
left a comment
There was a problem hiding this comment.
Is there any route that's using these templates:
src/Blog/templates/page/contact.html.twigsrc/Blog/templates/page/dotkernel-packages-oss-lifecycle.html.twig
I can't find them.
|
|
||
| private function notFound(?string $categorySlug): HtmlResponse | ||
| { | ||
| $categories = $this->categoryRepository->getCategories(); |
There was a problem hiding this comment.
Another database fetch duplication here - please fix.
| if (! $category) { | ||
| return new HtmlResponse('Category not found', 404); | ||
| return new HtmlResponse('Category not found', StatusCodeInterface::STATUS_NOT_FOUND); | ||
| } |
There was a problem hiding this comment.
Just asking (if you have specs telling otherwise, you don't need to change anything).
Wouldn't it be better to apply here the same logic that you did in the post handler?
I mean: if the category was not found, then show the 404 Not Found page with other category/post suggestions?
2 participants
Static pages and generic route