Refactor event stream to support dynamic discovery of new streams and event types.#158
Open
jmalloc wants to merge 10 commits into
Open
Refactor event stream to support dynamic discovery of new streams and event types.#158jmalloc wants to merge 10 commits into
jmalloc wants to merge 10 commits into
Conversation
Member
Author
|
Danil / Troy, this is a PR for those event stream gRPC changes I was talking about earlier. Basically would just like a proof-read / understanding check of the new structure in https://github.com/dogmatiq/enginekit/blob/90b46bcff2958620f12b7b2736889751b4ec4a8b/grpc/eventstreamgrpc/consume.proto (probably easier that trying to read the diff) 🙏 |
Member
Author
|
This does not include the new operation for discovery we discussed - the one that would be sent when a new engine boots up. |
danilvpetrov
approved these changes
Jul 8, 2026
|
|
||
| // ConsumeAPI is a service for consuming events from an offset-based ordered | ||
| // stream. | ||
| // ConsumeAPI is a service for consuming event messages from a offset-based, |
Member
There was a problem hiding this comment.
Suggested change
| // ConsumeAPI is a service for consuming event messages from a offset-based, | |
| // ConsumeAPI is a service for consuming event messages from offset-based, |
Co-authored-by: Danil Petrov <danilpetrovvi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.