chore: remove empty theme-extensions and theme-forms files [Draft]#8564
chore: remove empty theme-extensions and theme-forms files [Draft]#8564joakbjerk wants to merge 5 commits into
Conversation
|
Branch Preview URL (stable): Deployment URL (unique): |
commit: |
| ### Import extensions styles | ||
|
|
||
| The styles for extensions are not a part of the default styles, so you have to import them explicitly. | ||
|
|
||
| ```js | ||
| import '@dnb/eufemia/style/themes/ui/extensions' | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Let's discuss if this is "safe" to remove now or if we should wait until v12 🤔
Could this PR be breaking for any of our consumers who do import '@dnb/eufemia/style/themes/ui/extensions'? If so, I guess we could still keep the "export" (even though it will not to anything) with a TODO comment for remember to removing it in v12.
There was a problem hiding this comment.
Yeah, that might be a bit breaking 😄
| expect(global.components[0]).toContain('@charset "UTF-8";') | ||
| expect(global.components[0]).not.toContain(';--') | ||
| expect(global.components[0]).not.toContain('}:root{--') | ||
|
|
||
| expect(global.components[1]).toContain('@charset "UTF-8";') |
There was a problem hiding this comment.
Hmm, looks a bit suspicious 🤔
There was a problem hiding this comment.
it was to circumvent importing empty files, since there weren't any UTF-8 characters in there when empty, but probably not the best way to solve this no 🤔
2 participants
Testing out if its easily done, and breaking to much 😅