grid_integrate: deposit the specific energy spectrum at interaction p…#5
Merged
Merged
Conversation
…oints Only the scalar specific energy received the partial-path deposit when a photon interacted inside a cell; the frequency-resolved spectrum (specific_energy_sum_spectrum) was only deposited at wall crossings. The binned spectrum was therefore biased low in any cell optically thick enough for photons to interact within a single crossing -- measured at 20% low for tau_V ~ 0.1-1 up to ~7x low for tau_V > 10 on a galaxy simulation snapshot, while the bolometric (scalar) energy was correct. Mirror the wall-crossing spectrum deposit at the interaction point with the partial path length tact, so both arrays receive identical increments and the spectrum's bin-sum closes on the scalar exactly (verified closure = 1.0000 in every cell of an optically thick test model with the equivalent fix on the pre-rewrite branch, vs 0.12-0.97 without it). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…oints
Only the scalar specific energy received the partial-path deposit when a photon interacted inside a cell; the frequency-resolved spectrum (specific_energy_sum_spectrum) was only deposited at wall crossings. The binned spectrum was therefore biased low in any cell optically thick enough for photons to interact within a single crossing -- measured at 20% low for tau_V ~ 0.1-1 up to ~7x low for tau_V > 10 on a galaxy simulation snapshot, while the bolometric (scalar) energy was correct.
Mirror the wall-crossing spectrum deposit at the interaction point with the partial path length tact, so both arrays receive identical increments and the spectrum's bin-sum closes on the scalar exactly (verified closure = 1.0000 in every cell of an optically thick test model with the equivalent fix on the pre-rewrite branch, vs 0.12-0.97 without it).