feat: Node test fixtures#2545
Draft
trisyoungs wants to merge 6 commits into
Draft
Conversation
…plus data deserialisation.
trisyoungs
force-pushed
the
dissolve2/node-test-fixtures
branch
from
87b4480 to
1506873
Compare
rprospero
approved these changes
Jun 30, 2026
| // Deserialised graph | ||
| DissolveGraph deserialisedGraph_; | ||
| // Current graph target | ||
| OptionalReferenceWrapper<DissolveGraph> currentGraph_; |
Contributor
There was a problem hiding this comment.
Perhaps go ahead and make this DissolveGraph* ? I know that eventually removing OptionalReferenceWrapper is on the RoadMap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a sort of fixture-based approach to more full-range testing of Graphs, particularly those involving analysis nodes calculating a specific result. The idea is to define the setup, run, and test functions individually, and then let the fixture setup, run, test. This automation then allows serialisation round-trip testing for free, as well as restart-data reading / testing when we are ready.