[Feature] Update Logging#81
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
All warnings were emitted via the root logger (
logging.warning(...)), making it impossible for consumers to silence or configurehtml4docxoutput without affecting their entire application logging.Changes
Logging overhaul
logger = logging.getLogger(__name__)toh4d.py,utils.py, andmetadata.pyNullHandleron the package root (__init__.py) keeps the library silent by default — no handler needed per-modulelogging.<level>(...)andprint(...)warning calls withlogger.<level>(...)across all three modulesWARNING→DEBUG(expected skips for any real-world HTML, not actionable problems)Tests
test_custom_style_not_found_warningto assert against the named loggerhtml4docx.h4dtest_metadata.pywarning tests fromcapsys(stdout) →caplog(named logger)NullHandlerplacement, and that warnings are silenceable per-loggerDocs
README.mdwith recipes for silencing output in plain Python, DjangoLOGGINGdict, and enabling debug-level detailLinter
ruffoffenses (SIM118,SIM401,SIM102,SIM201,SIM108,UP031,B905,B011)Result
Consumers can now silence all
html4docxoutput with a single config entry:Issue Reference
Fixes #80
Checklist Before Requesting a Review