fix: ANRs in main thread#632
Open
martinpelli wants to merge 1 commit into
Open
Conversation
Owner
|
@martinpelli Thank you for the PR. I will check. Since you have put the initialization on a separate thread, I'm worried that it could trigger another issue |
Author
|
@deepak786 thanks! The thread is spawned from within |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix ANRs issues mentioned in #629
Description
Fixes ANR triggered during app startup on Android when
Intercom.initializeis called fromApplication.onCreate.Intercom.initializeinternally callsUserIdentityStore.loadUserFieldsusingrunBlockingover DataStore/Keystore operations. When invoked on the main thread, this blocks it for >5s on low-end devices (Tecno, Infinix), causing an ANR.Changes
initSdknow spawns a daemon background thread"intercom-init"to runIntercom.initializeoff the main threadCountDownLatch(1)that gates all method calls — any call arriving before init completes waits on a background thread, then posts back to main once the latch releaseslatch.count == 0Lshort-circuits the wait with zero overheadonMethodCallnow delegates to a privatedispatch(call, result)wrapped inrunAfterInit— no per-method changes neededIntercom.initialized(Future<void>) on the Dart side that completes wheninitialize()finishes, for clients that want to explicitly await readiness