Backport: fix(vm): avoid false no bootable device events from EFI shell#2464
Merged
eofff merged 1 commit intoJun 10, 2026
Merged
Conversation
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
diafour
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a downstream EDK2 shell patch that moves the
No bootable device.debug-port marker from unconditional shell startup to the interactive fallback shell path only.The patch now checks that the EFI shell was started without a target file and without a
Startup.nshscript before writing the marker to debug port0x403. The patches README was updated to document the new downstream patch and patch ordering.Why do we need it, and what problem does it solve?
Some operating systems legitimately launch the EFI shell with startup parameters or scripts. Emitting
No bootable device.at every shell entry makes QEMU report aNO_BOOTABLE_DEVICEevent even when the VM boot flow is valid.This change keeps real firmware fallback detection intact while avoiding false no-bootable-device reports for normal parameterized EFI shell launches.
What is the expected result?
A VM that really falls back to the EFI shell without a bootable device still emits
No bootable device.and produces the expectedNO_BOOTABLE_DEVICEevent.A VM or OS flow that starts the EFI shell with a file, options, or
Startup.nshno longer emits the marker and is not treated as a no-bootable-device failure.Checklist
Changelog entries