Skip to content

fix(e2e): use fixed header height in viewport fixture#6776

Open
nmerget wants to merge 3 commits into
mainfrom
fix-snapshot-header-height
Open

fix(e2e): use fixed header height in viewport fixture#6776
nmerget wants to merge 3 commits into
mainfrom
fix-snapshot-header-height

Conversation

@nmerget
Copy link
Copy Markdown
Collaborator

@nmerget nmerget commented May 22, 2026

Proposed changes

Replace dynamic header height fetching with a fixed value. scrollHeight includes hidden sub-navigation items, whose height increases with each new component added to the navigation, causing inconsistent viewport sizes across test runs.

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/fix-snapshot-header-height

Replace dynamic header height fetching with a fixed value.
scrollHeight includes hidden sub-navigation items, whose height
increases with each new component added to the navigation,
causing inconsistent viewport sizes across test runs.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 22, 2026

⚠️ No Changeset found

Latest commit: 430ed93

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the 📺showcases Changes to 1-n showcases label May 22, 2026
@nmerget nmerget moved this from 🏗 In progress to 🎁 Ready for review in UX Engineering Team Backlog May 22, 2026
@nmerget nmerget enabled auto-merge (squash) May 22, 2026 09:51
github-actions Bot and others added 2 commits May 22, 2026 10:22
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📺showcases Changes to 1-n showcases

Projects

Status: 🎁 Ready for review

Development

Successfully merging this pull request may close these issues.

1 participant