Skip to content

Add Tokyo Stock Exchange (TSE) stock symbols#1889

Merged
bodiam merged 2 commits into
datafaker-net:mainfrom
yuokada:stock-tse
Jul 23, 2026
Merged

Add Tokyo Stock Exchange (TSE) stock symbols#1889
bodiam merged 2 commits into
datafaker-net:mainfrom
yuokada:stock-tse

Conversation

@yuokada

@yuokada yuokada commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Overview

This pull request adds support for generating Tokyo Stock Exchange (TSE) stock symbols in the Stock provider. The main changes include adding a new method to fetch TSE symbols, updating the resource file with TSE symbol data, and ensuring the new method is covered by tests.

Support for Tokyo Stock Exchange (TSE) symbols:

@what-the-diff

what-the-diff Bot commented Jul 23, 2026

Copy link
Copy Markdown

PR Summary

  • New Method for Handling TSE Stock Symbols
    A fresh method named tseSymbol() has been introduced in the Stock.java file. This method will help in managing and resolving stock symbols for the Tokyo Stock Exchange (TSE).

  • Addition of New Stock Codes
    The stock.yml file has been updated. As part of this update, a new entry (symbol_tse) has been created which includes multiple stock codes, increasing the breadth of financial data available in our systems.

  • Enhanced Testing
    To ensure quality and performance, the StockTest.java file has been modified to include a new test case, specifically for the tseSymbol() method that was just introduced. This not only validates the new feature but also helps maintain a robust system by detecting any potential issues early.

@codecov-commenter

codecov-commenter commented Jul 23, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.55%. Comparing base (2729350) to head (f3db849).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1889      +/-   ##
============================================
- Coverage     92.58%   92.55%   -0.03%     
  Complexity     3572     3572              
============================================
  Files           347      347              
  Lines          7051     7052       +1     
  Branches        675      675              
============================================
- Hits           6528     6527       -1     
- Misses          364      365       +1     
- Partials        159      160       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yuokada
yuokada marked this pull request as ready for review July 23, 2026 07:24
@yuokada yuokada changed the title Add TSE stock symbols Add Tokyo Stock Exchange (TSE) stock symbols Jul 23, 2026
@asolntsev asolntsev added this to the 3.0.0 milestone Jul 23, 2026
@asolntsev asolntsev added the enhancement New feature or request label Jul 23, 2026
@bodiam

bodiam commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Thanks!!

@bodiam
bodiam merged commit c367845 into datafaker-net:main Jul 23, 2026
17 checks passed
@yuokada
yuokada deleted the stock-tse branch July 24, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants