test: raise dbt-tests-adapter floor to >=1.20.0 for persist_docs fixture rename#1490
Open
sd-db wants to merge 2 commits into
Open
test: raise dbt-tests-adapter floor to >=1.20.0 for persist_docs fixture rename#1490sd-db wants to merge 2 commits into
sd-db wants to merge 2 commits into
Conversation
…ure rename dbt-tests-adapter 1.20.0 corrected a long-standing typo in a persist_docs fixture name (_PROPERITES__SCHEMA_MISSING_COL -> _PROPERTIES__SCHEMA_MISSING_COL) and removed the old name. Our reference to the old spelling broke as soon as CI resolved 1.20.0. Raise the test-dependency floor to >=1.20.0 (regenerating requirements.lowest-direct.txt and uv.lock) and update the functional test to the corrected name, so both the min-deps and latest resolutions use the new spelling without a compatibility shim. Test-only change; dbt-tests-adapter is not a runtime dependency.
sd-db
force-pushed
the
sd-db/fix/persist-docs-fixture-rename
branch
from
5e143be to
59483a3
Compare
Coverage report
This PR does not seem to contain any modification to coverable code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dbt-tests-adapter1.20.0 fixed a typo in apersist_docsfixture name (_PROPERITES__SCHEMA_MISSING_COL→_PROPERTIES__SCHEMA_MISSING_COL) and dropped the old spelling, breaking our test as CI resolved1.12.0Raise the test-dep floor to
>=1.20.0(regeneratingrequirements.lowest-direct.txt+uv.lock) and use the corrected name.Test-only —
dbt-tests-adapterisn't a runtime dependency. Verified: livetest_missing_columnpasses; pre-commit clean.