Skip to content

refactor(dashcore): removed Address::network() and replace Network with AddressPrefix#802

Merged
xdustinface merged 1 commit into
devfrom
poc/network-refactor
Jun 15, 2026
Merged

refactor(dashcore): removed Address::network() and replace Network with AddressPrefix#802
xdustinface merged 1 commit into
devfrom
poc/network-refactor

Conversation

@ZocoLini

@ZocoLini ZocoLini commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@ZocoLini, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 5 minutes. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6656589b-7284-4c12-8e59-cb0d68f42c14

📥 Commits

Reviewing files that changed from the base of the PR and between 4d529e4 and 43cbf24.

📒 Files selected for processing (5)
  • dash/src/address.rs
  • dash/src/sign_message.rs
  • key-wallet-ffi/src/transaction.rs
  • key-wallet/src/account/bls_account.rs
  • key-wallet/tests/address_tests.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch poc/network-refactor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.91%. Comparing base (4d529e4) to head (43cbf24).

Files with missing lines Patch % Lines
dash/src/address.rs 87.17% 5 Missing ⚠️
key-wallet-ffi/src/transaction.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #802      +/-   ##
==========================================
- Coverage   72.94%   72.91%   -0.03%     
==========================================
  Files         323      323              
  Lines       71989    71994       +5     
==========================================
- Hits        52511    52494      -17     
- Misses      19478    19500      +22     
Flag Coverage Δ
core 76.74% <87.50%> (-0.01%) ⬇️
ffi 46.99% <0.00%> (ø)
rpc 20.00% <ø> (ø)
spv 90.20% <ø> (-0.12%) ⬇️
wallet 71.64% <100.00%> (ø)
Files with missing lines Coverage Δ
dash/src/sign_message.rs 79.85% <100.00%> (ø)
key-wallet/src/account/bls_account.rs 53.99% <100.00%> (ø)
key-wallet-ffi/src/transaction.rs 0.00% <0.00%> (ø)
dash/src/address.rs 57.50% <87.17%> (-0.09%) ⬇️

... and 4 files with indirect coverage changes

Comment thread dash/src/address.rs Outdated
@ZocoLini ZocoLini force-pushed the poc/network-refactor branch from 1f147f0 to a943ed2 Compare June 15, 2026 12:43
@ZocoLini ZocoLini marked this pull request as ready for review June 15, 2026 12:44
@ZocoLini ZocoLini changed the title refactor(dashcore): replace Network field in Address with NetworkScope refactor(dashcore): replace Network field in Address with NetworkPrefix Jun 15, 2026
@ZocoLini ZocoLini force-pushed the poc/network-refactor branch from a943ed2 to 8f31229 Compare June 15, 2026 12:46
@ZocoLini ZocoLini changed the title refactor(dashcore): replace Network field in Address with NetworkPrefix refactor(dashcore): removed Address::network() and replace Network with AddressPrefix Jun 15, 2026
@ZocoLini ZocoLini force-pushed the poc/network-refactor branch from 8f31229 to 43cbf24 Compare June 15, 2026 12:48
@ZocoLini ZocoLini requested a review from xdustinface June 15, 2026 12:51
@github-actions github-actions Bot added the ready-for-review CodeRabbit has approved this PR label Jun 15, 2026
@xdustinface xdustinface merged commit 5c0113e into dev Jun 15, 2026
35 checks passed
@xdustinface xdustinface deleted the poc/network-refactor branch June 15, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review CodeRabbit has approved this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants