Skip to content

enh: add Macaca radiata (bonnet macaque) to species_map#1865

Open
yarikoptic wants to merge 1 commit into
masterfrom
enh-macaca-radiata
Open

enh: add Macaca radiata (bonnet macaque) to species_map#1865
yarikoptic wants to merge 1 commit into
masterfrom
enh-macaca-radiata

Conversation

@yarikoptic
Copy link
Copy Markdown
Member

Adds NCBI taxon 9548 (Macaca radiata, common name "bonnet macaque") to the species lookup table so the species can be recognized by common name, "radiata", or its NCBITaxon URL.

Requested by a user via email.

@yarikoptic yarikoptic added patch Increment the patch version when merged release Create a release when this pr is merged labels May 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.74%. Comparing base (8fa9188) to head (813fb8e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1865      +/-   ##
==========================================
- Coverage   76.76%   76.74%   -0.03%     
==========================================
  Files          87       87              
  Lines       12769    12769              
==========================================
- Hits         9802     9799       -3     
- Misses       2967     2970       +3     
Flag Coverage Δ
unittests 76.74% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread dandi/metadata/util.py
["bonnet macaque", "bonnet monkey", "radiata"],
None,
NCBITAXON_URI_TEMPLATE.format("9548"),
"Macaca radiata - Bonnet macaque",
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this version is better than just

Suggested change
"Macaca radiata - Bonnet macaque",
"Macaca radiata",

as we did for "Macaca nemestrina" above . I think we should expand all others into similar

{current name} - {Genbank common name} form which seems they all follow.

@copilot -- prepare a PR where all other entries follow the same format for their "name" and also expand description above on the expected format of the "name" field

Copy link
Copy Markdown
Contributor

Copilot AI commented May 28, 2026

@yarikoptic I've opened a new pull request, #1866, to work on those changes. Once the pull request is ready, I'll request review from you.

@yarikoptic yarikoptic requested a review from CodyCBakerPhD May 29, 2026 03:33
Adds NCBI taxon 9548 (Macaca radiata, common name "bonnet macaque") to
the species lookup table so the species can be recognized by common
name, "radiata", or its NCBITaxon URL.

Requested by a user via email.

Co-Authored-By: Claude Code 2.1.154 / Claude Opus 4.7 <noreply@anthropic.com>
@yarikoptic yarikoptic force-pushed the enh-macaca-radiata branch from 1a2d7a9 to 813fb8e Compare May 29, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged release Create a release when this pr is merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants