fix: create /app before writing version (build is broken on main)#2
Closed
jtrotsky wants to merge 1 commit into
Closed
fix: create /app before writing version (build is broken on main)#2jtrotsky wants to merge 1 commit into
jtrotsky wants to merge 1 commit into
Conversation
The build failed at the npm RUN step: it redirected `npm list ... > /app/version` but nothing created /app, so the shell errored with "cannot create /app/version: No such file or directory". - mkdir -p /app before writing the version file - sed -n 's/.*@//p' so only the @immich/cli line is emitted (npm list prints the prefix path as its first line, which otherwise leaked into the version string) - chmod /app world-readable so the unprivileged bsd user can read /app/version at runtime Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merged image fails to build. The npm
RUNstep redirectsnpm list -g @immich/cli --depth=0 | sed ... > /app/version, but nothing creates/appfirst, so the build dies with:This fixes it:
mkdir -p /appbefore writing the version file.sed -n 's/.*@//p'instead ofsed 's/.*@//'—npm list -gprints the prefix path (/usr/local/lib) as its first line, which leaked into the version string and produced a two-line/app/version. The-n ... pform emits only the@immich/cli@…line.chmod/appalongsidenode_modulesso the unprivilegedbsduser can read/app/versionat runtime.Changes are in
Containerfile.j2(source) and the generatedContainerfile.Verified locally:
dbuild buildcompletes and the version probe reports2.7.5.