feat(page-cluster): merge clusters sharing a rare landmark variant#914
Merged
Merged
Conversation
Reimplements a previously withdrawn "landmark-gated tertiary cluster" mechanism with the missing safeguard: a header/footer/nav/aside match only counts as merge evidence when that specific variant is rare corpus-wide (landmarkRarityThreshold), not merely identical. The withdrawn prototype merged on identity alone and over-merged on real crawl data, since header/footer/nav are present on 99%+ of pages. Adds `mergeRareLandmarkClusters` (default false) to resolvePageClusterKeys, backed by a new mergeLandmarkAffinedClusters()/validateMergeLandmarkAffinedClustersOptions() pair in a new file. Re-keying happens at page granularity, not whole-cluster, so a coincidental match between a couple of outlier pages cannot drag their entire, otherwise-unrelated clusters together. Real-corpus validation is out of scope for this change (the crawl data used previously is not in this repository); this ships with synthetic-fixture unit and regression tests only.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mergeRareLandmarkClusters, defaultfalse) with the missing safeguard: a header/footer/nav/aside match only counts as merge evidence when that specific variant is rare corpus-wide (landmarkRarityThreshold), not merely identical — the withdrawn prototype merged on identity alone and over-merged on real crawl data since header/footer/nav are present on 99%+ of pages.merge-landmark-affined-clusters.ts(mergeLandmarkAffinedClusters()/validateMergeLandmarkAffinedClustersOptions()), wired intoresolvePageClusterKeys(). Re-keying happens at page granularity, not whole-cluster, so a coincidental match between a couple of outlier pages cannot drag their entire, otherwise-unrelated clusters together.exportsupdated; new subpath@d-zero/page-cluster/merge-landmark-affined-clusters.Test plan
yarn lint— 0 errorsyarn build— all 28 packages buildyarn test— 1467/1467 pass (monorepo-wide)/code-review xhigh(9 confirmed/plausible findings fixed: missing self-validation, partial-evidence-applied-to-whole-cluster over-merge, landmark-markup leaking into the "independent" content gate, unsafe token-set canonicalization, broken JSDoc cross-references) and/qa-engineer(added a regression test for a previously-untested fuzzy landmark-variant-matching code path)🤖 Generated with Claude Code