Avoid flipping displayStatus None -> True on explicit naturals#1975
Merged
mscuthbert merged 1 commit intoJul 9, 2026
Merged
Conversation
jacobtylerwalls
commented
Jul 5, 2026
| self.assertIsNone(last_note.pitch.accidental.displayStatus) | ||
| p.makeAccidentals(inPlace=True) | ||
| self.assertIs(first_note.pitch.accidental.displayStatus, False) | ||
| self.assertIs(last_note.pitch.accidental.displayStatus, False) |
Member
Author
There was a problem hiding this comment.
Only this last assertion failed before.
| # and it is not a natural, it should always be set to display | ||
| if (pPastInMeasure is False | ||
| and acc is not None | ||
| and acc.name != 'natural' |
Member
Author
There was a problem hiding this comment.
See "not a natural" in the above comment.
jacobtylerwalls
force-pushed
the
jtw/spurious-natural
branch
from
bdbe229 to
28bbde5
Compare
mscuthbert
approved these changes
Jul 9, 2026
| # and it is not a natural, it should always be set to display | ||
| if (pPastInMeasure is False | ||
| and acc is not None | ||
| and acc.name != 'natural' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the bottom of the bug report in cuthbertLab/music21j#315 (comment), I noticed that for a stream like
d1 d1, when applying aNaturalaccidental to both notes with a displayStatus of None, only subsequent ones had an explicitdisplayStatus = True.