Skip to content

Create Corner_Helicopter_2x2.svg#205

Open
hopz123 wants to merge 2 commits into
cubing:mainfrom
hopz123:patch-33
Open

Create Corner_Helicopter_2x2.svg#205
hopz123 wants to merge 2 commits into
cubing:mainfrom
hopz123:patch-33

Conversation

@hopz123

@hopz123 hopz123 commented Nov 14, 2025

Copy link
Copy Markdown

No description provided.

@jfly jfly left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename to match our other icon names (lowercase).

@lgarron

lgarron commented Nov 15, 2025

Copy link
Copy Markdown
Member

Also a few requests:

  • I think this should be corner_helicopter_2x2x2 or corner_helicopter_222
  • The rounding of corners is a bit inconsistent. We're also not 100% consistent across all our icons, but I think they should be sharp rather than beveled/rounded unless this causes rending issues.
  • I think this is quite pleasing at large scale, but the corners get very narrow at small scales. Is it possible to adjust the cuts so the stickers are closer to equal size?

@jfly

jfly commented Jan 13, 2026

Copy link
Copy Markdown
Member

@hopz123, looks like the tests are failing with this new icon. Please fix and we can merge this.

@lgarron

lgarron commented Jan 15, 2026

Copy link
Copy Markdown
Member

I still have a few concerns about this icon. In addition to the points above, it's also much larger than necessary — almost twice as large as any other event icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants