Remove duplicate run call for ApplicationRunner#1887
Conversation
Removed duplicate runner.run(Component) call. In python wamp pubsub basic example.
|
Thanks for this, @JavierSab — nice catch! 🙌 The change is correct: that second A few small process bits before we can merge. Up front: some of these aren't So I filed: #1889 And for your specific issue this PR fixes: #1888
No tests needed for an example-file cleanup like this. Once the issue reference |
|
@JavierSab thanks for adding an audit file! I now approved to run CICD, let's see. because, sorry, there is still a small itch with the audit file contents, it doesn't reference the issue #1888 I added in I still approved to run, since I wanted to give you some "positive success" feedback already, and because I want to know whether our CICD would detect the missing issue reference automatically, and fail! which it might not yet do - which would be something for us to improve then. |
|
more notes: 1. Rename the audit file (this is what's failing CI ✋)The Windows CI job is failing at checkout with: The cause is the The convention is git mv ".audit/JavierSab:patch-1.md" .audit/JavierSab_patch-1.md
git commit -m "Rename audit file to valid cross-platform name"(compare existing files, e.g. 2. Reference the issue in the audit file (+ PR)Now that there's an issue for this (#1888 — thanks for bearing with the
|
Removed duplicate runner.run(Component) call. In python wamp pubsub basic example.
Description
Removal of a duplicate
run()line in one of the WAMP simple pubsub client examples.Related Issue(s)
Closes or relates to #
Checklist
the style guidelines of this project
is effective or that my feature works
updated the changelog
in this PR
AI Assistance Disclosure File
file at
.audit/<branch-name>.mdright in this PR. Thedisclosure file must follow the exact format and content as
described below. Your PR will not be accepted without a
disclosure file.
Example 1 file contents of your disclosure file
.audit/<branch-name>.md:OR
Example 2 file contents of your disclosure file
.audit/<branch-name>.md:Submitting code generated primarily by AI, or for which you
cannot claim human authorship, is not permitted. See
AI Policy
for details.
Example 1 OR Example 2 show the only valid two variants. You
cannot have both or none of the first two marks checked, and you
must always have the last tick checked.
Well, "must" if you want your PR to be accepted and ultimately
merged that is. Of course you are always free to
Go ahead! Fork my Day. (TM);) This is Open-source.