-
Notifications
You must be signed in to change notification settings - Fork 56
RCBC-551: FIT performer - add support for CounterEq bounds type #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DemetrisChr
merged 1 commit into
couchbase:main
from
DemetrisChr:RCBC-551-countereq-bounds
Jul 8, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| # Copyright 2026-Present Couchbase, Inc. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| require_relative 'bounds/simple' | ||
| require_relative 'bounds/for_time' | ||
| require_relative 'bounds/counter_equality' | ||
| require_relative 'bounds/counter' | ||
|
|
||
| module FIT | ||
| module Performer | ||
| module Bounds | ||
| def self.create_bounds(raw_workload, global_counters) | ||
| return Simple.new(raw_workload.command.size) unless raw_workload.has_bounds? | ||
|
|
||
| raw_bounds = raw_workload.bounds | ||
| case raw_bounds.bounds | ||
| when :counter | ||
| counter_id = raw_bounds.counter.counter_id | ||
| initial_value = raw_bounds.counter.global.count | ||
| global_counter = global_counters.get_counter(counter_id, initial_value) | ||
| Counter.new(global_counter) | ||
|
|
||
| when :for_time | ||
| ForTime.new(raw_bounds.for_time.seconds) | ||
|
|
||
| when :counter_eq | ||
| counter_id = raw_bounds.counter_eq.counter_id | ||
| initial_value = raw_bounds.counter_eq.global.count | ||
| global_counter = global_counters.get_counter(counter_id, initial_value) | ||
| CounterEquality.new(global_counter, initial_value) | ||
|
|
||
| else | ||
| raise PerformerError, "Bounds type `#{raw_bounds.bounds}` not recognised" | ||
| end | ||
| end | ||
| end | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| # Copyright 2026-Present Couchbase, Inc. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| module FIT | ||
| module Performer | ||
| module Bounds | ||
| # A bounds implementation that executes commands for a specified number of times, based on a global counter. | ||
| # The global counter may be shared with other workloads. | ||
| class Counter | ||
| # Initializes a new instance of the Counter bounds implementation. | ||
| # | ||
| # @param global_counter [Concurrent::AtomicFixnum] The global counter to use for determining if the workload | ||
| # can execute. | ||
| def initialize(global_counter) | ||
| @global_counter = global_counter | ||
| end | ||
|
|
||
| def can_execute? | ||
| @global_counter.decrement >= 0 | ||
| end | ||
| end | ||
| end | ||
| end | ||
| end |
38 changes: 38 additions & 0 deletions
38
fit-performer/lib/fit/performer/bounds/counter_equality.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| # Copyright 2026-Present Couchbase, Inc. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| module FIT | ||
| module Performer | ||
| module Bounds | ||
| # A bounds implementation that executes commands while a global counter remains unchanged. | ||
| class CounterEquality | ||
| # Initializes a new instance of the CounterEquality bounds implementation. | ||
| # | ||
| # @param global_counter [Concurrent::AtomicFixnum] The global counter to use for determining if the workload | ||
| # can execute. | ||
| # @param initial_value [Integer] The initial value of the counter to compare against | ||
| def initialize(global_counter, initial_value) | ||
| @global_counter = global_counter | ||
| @initial_value = initial_value | ||
| end | ||
|
|
||
| def can_execute? | ||
| @global_counter.value == @initial_value | ||
| end | ||
| end | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| # Copyright 2026-Present Couchbase, Inc. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| module FIT | ||
| module Performer | ||
| module Bounds | ||
| # A bounds implementation that executes commands for a specified duration of time. | ||
| class ForTime | ||
| def initialize(duration_seconds) | ||
| @deadline = Time.now + duration_seconds | ||
| end | ||
|
|
||
| def can_execute? | ||
| Time.now < @deadline | ||
| end | ||
| end | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| # Copyright 2026-Present Couchbase, Inc. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| module FIT | ||
| module Performer | ||
| module Bounds | ||
| # A simple bounds implementation that executes every command in the workload once. | ||
| class Simple | ||
| def initialize(command_count) | ||
| @remaining_command_count = command_count | ||
| end | ||
|
|
||
| def can_execute? | ||
| @remaining_command_count -= 1 | ||
| @remaining_command_count >= 0 | ||
| end | ||
| end | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| # Copyright 2026-Present Couchbase, Inc. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| require 'concurrent/atomic/atomic_fixnum' | ||
|
DemetrisChr marked this conversation as resolved.
|
||
|
|
||
| module FIT | ||
| module Performer | ||
| class Counters | ||
| def initialize | ||
| @counters = {} | ||
| @mutex = Mutex.new | ||
| end | ||
|
|
||
| def clear | ||
| @mutex.synchronize do | ||
| @counters.clear | ||
| end | ||
| end | ||
|
DemetrisChr marked this conversation as resolved.
|
||
|
|
||
| def set_counter_value(counter_id, value) | ||
| @mutex.synchronize do | ||
| if @counters.key?(counter_id) | ||
| @counters[counter_id].value = value | ||
| else | ||
| @counters[counter_id] = Concurrent::AtomicFixnum.new(value) | ||
| end | ||
| end | ||
| end | ||
|
|
||
| def get_counter(counter_id, initial_value = nil) | ||
| @mutex.synchronize do | ||
| return @counters[counter_id] if @counters.key?(counter_id) | ||
|
|
||
| raise PerformerError, "Counter #{counter_id} does not exist and no initial value was provided" if initial_value.nil? | ||
|
|
||
| @counters[counter_id] = Concurrent::AtomicFixnum.new(initial_value) | ||
| end | ||
| end | ||
| end | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.