-
Notifications
You must be signed in to change notification settings - Fork 60
Update github actions (main) (minor) #3282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,4 +29,4 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Label PR by size | ||
| uses: conforma/pr-size-label-action@v1.0.0 | ||
| uses: conforma/pr-size-label-action@v1.2.0 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [medium] action-pinning conforma/pr-size-label-action is pinned to a mutable version tag (v1.2.0) rather than an immutable commit SHA. Every other third-party action in this repository is pinned to a full 40-character commit SHA with a version comment. This workflow runs on pull_request_target with pull-requests: write and issues: write permissions, which increases the impact of a supply chain compromise if the tag is force-pushed. Suggested fix: Pin to the commit SHA corresponding to v1.2.0, e.g.: uses: conforma/pr-size-label-action@ # v1.2.0 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] supply-chain conforma/pr-size-label-action is referenced by mutable tag (v1.2.0) without SHA pinning. This action runs on the pull_request_target trigger with write permissions to pull-requests and issues. However, this follows the established repository convention: all conforma/ org-owned actions are referenced by branch or tag rather than SHA. The risk is mitigated by the action being owned by the same organization. Suggested fix: Consider SHA-pinning all conforma/ org-owned actions for defense-in-depth, but this is a broader policy decision, not specific to this PR. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] supply-chain-security conforma/pr-size-label-action is referenced by mutable tag (@v1.2.0) instead of a commit SHA pin. All other actions in the repository use SHA pinning. This is a pre-existing pattern not introduced by this PR, but adding a SHA pin would improve consistency with the supply chain security posture. Suggested fix: Pin conforma/pr-size-label-action to a commit SHA, e.g.: uses: conforma/pr-size-label-action@ # v1.2.0 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] supply-chain conforma/pr-size-label-action is referenced by mutable tag (v1.2.0) instead of a pinned commit SHA, unlike all other actions in this repository. Tags can be reassigned, weakening supply chain integrity. This is a pre-existing pattern (was v1.0.0 before this PR) and the action is organization-internal. Suggested fix: Pin to a specific commit SHA with a version comment, e.g.: uses: conforma/pr-size-label-action@9bff907 # v1.2.0 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] supply-chain Pre-existing: conforma/pr-size-label-action uses a mutable tag reference (@v1.2.0) instead of a commit SHA pin, inconsistent with all other actions in this repository. This workflow runs on pull_request_target with pull-requests: write permissions. While it is a first-party action (same org), SHA pinning would provide stronger supply chain protection. Suggested fix: Pin to a full 40-character commit SHA: conforma/pr-size-label-action@ # v1.2.0 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] security/supply-chain conforma/pr-size-label-action is pinned to a mutable version tag (v1.2.0) instead of a commit SHA. All other actions in this repository use SHA pinning for supply-chain security. While the risk is mitigated by the action being owned by the same organization, pinning to a commit SHA would be consistent with the repos security posture. Suggested fix: Replace |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[low] pattern-inconsistency
conforma/pr-size-label-action is pinned to a mutable tag (@v1.2.0) rather than a commit SHA, unlike every other action reference in this repository. This is a pre-existing pattern (was @v1.0.0), not introduced by this PR. This action runs on pull_request_target with pull-requests: write and issues: write permissions, making SHA pinning especially important for supply-chain security.
Suggested fix: Pin to a full commit SHA with a version comment, e.g., uses: conforma/pr-size-label-action@ # v1.2.0