Replace editorState option with inlineEditing#2430
Merged
Conversation
The previous `editorState` option in `renderInContentElement` let specs
splat arbitrary keys into the editor state context, and the helper
always wrapped its children with inline-editing-only providers
(DndProvider, the editor command emitter context) even for frontend-
mode tests.
The new `inlineEditing` option is explicit: when set, inline-editing
providers wrap the tree and the editor state context is overridden;
when omitted, content elements see the frontend-mode defaults that
match production. The value is either `true` for editable defaults or
`{isEditable, isSelected, transientState}` for granular control, where
`transientState` accepts a jest spy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous
editorStateoption inrenderInContentElementlet specs splat arbitrary keys into the editor state context, and the helper always wrapped its children with inline-editing-only providers (DndProvider, the editor command emitter context) even for frontend- mode tests.The new
inlineEditingoption is explicit: when set, inline-editing providers wrap the tree and the editor state context is overridden; when omitted, content elements see the frontend-mode defaults that match production. The value is eithertruefor editable defaults or{isEditable, isSelected, transientState}for granular control, wheretransientStateaccepts a jest spy.[skip percy]