Use fake parent window test helper#2428
Merged
Merged
Conversation
Inline editing only ever runs inside the editor's preview iframe in production, so `window.parent !== window` is always true and the postMessage listener in inline-editing's MessageHandler is always attached. Have the helper set that up by default so inline-editing specs no longer need to remember `fakeParentWindow()` per test.
Bundle the fake parent window setup AND its postMessage stub into a single setup hook so specs that need outgoing messages mocked can opt in with one line. `useInlineEditingPageObjects` calls it instead of the bare `fakeParentWindow()`; specs that previously paired `fakeParentWindow()` with `window.parent.postMessage = jest.fn()` drop both calls and use the hook directly. The shallow-equal transient state test in inEditorPreview-spec used to re-stub `window.parent.postMessage` mid-test before re-rendering. With the hook stubbing it once per beforeEach, switch to a `mockClear()` before the rerender and assert that no further posts happen, instead of asserting a total call count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.