refac(cs-flags): Split experiments into internal and preview#544
Open
nathanael-ruf wants to merge 1 commit into
Open
refac(cs-flags): Split experiments into internal and preview#544nathanael-ruf wants to merge 1 commit into
nathanael-ruf wants to merge 1 commit into
Conversation
nathanael-ruf
commented
Jun 30, 2026
Comment on lines
+31
to
+33
| // Experiments backs the deprecated --experiments flag; its values | ||
| // are folded into the internal bucket for backwards compatibility. | ||
| Experiments []string |
Member
Author
There was a problem hiding this comment.
Not sure if/who uses that flag. Up to you to eventually remove it.
nathanael-ruf
commented
Jun 30, 2026
Comment on lines
+127
to
+129
| InternalFlags []string `json:"internal"` | ||
| PreviewFlags []string `json:"preview"` | ||
| FeatureFlags []string `json:"feature_flags"` |
Member
Author
There was a problem hiding this comment.
Decided to make them all slices internally. I think that is easier to understand and it's good enough to convert to a map where needed when writing the config file.
Not sure why it's even inconsistent in the config.yml file.
Signed-off-by: Nathanael Ruf <nathanael@codesphere.com>
nathanael-ruf
force-pushed
the
nate/split-exp
branch
from
b653e59 to
9d2d3c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also enabled
workspace-sshpreview flag by default (was handed over to SRE yesterday).