Skip to content

feat: Add helm template support for rbac and deployment naming #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rowansmithau merged 2 commits into from
Jun 19, 2026
+13 −7
Merged

feat: Add helm template support for rbac and deployment naming #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec27d85
helm rbac templating added
rowansmithau Jun 19, 2026
56fc1e0
Update helm/values.yaml
rowansmithau Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions helm/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,20 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
name: coder-logstream-kube-role
name: {{ $.Values.rbac.roleName }}
namespace: {{ . }}
rules:
{{ include "coder-logstream-kube.rules" . | nindent 2 }}
---
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
name: coder-logstream-kube-rolebinding
name: {{ $.Values.rbac.roleBindingName }}
namespace: {{ . }}
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: Role
name: coder-logstream-kube-role
name: {{ $.Values.rbac.roleName }}
subjects:
- kind: ServiceAccount
name: {{ $.Values.serviceAccount.name | quote }}
Expand All @@ -40,18 +40,18 @@ subjects:
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: coder-logstream-kube-role
name: {{ $.Values.rbac.roleName }}
rules:
{{ include "coder-logstream-kube.rules" . | nindent 2 }}
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: coder-logstream-kube-rolebinding
name: {{ $.Values.rbac.roleBindingName }}
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: coder-logstream-kube-role
name: {{ $.Values.rbac.roleName }}
subjects:
- kind: ServiceAccount
name: {{ .Values.serviceAccount.name | quote }}
Expand All @@ -68,7 +68,7 @@ metadata:
apiVersion: apps/v1
kind: Deployment
metadata:
name: coder-logstream-kube
name: {{ .Release.Name }}
spec:
# This must remain at 1 otherwise duplicate logs can occur!
replicas: 1
Expand Down
6 changes: 6 additions & 0 deletions helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ serviceAccount:
# coder.serviceAccount.name -- The service account name
name: coder-logstream-kube

rbac:
# rbac.roleName -- The name of the role created in Kubernetes.
roleName: coder-logstream-kube-role
# rbac.roleBindingName -- The name of the role binding created in Kubernetes.
roleBindingName: coder-logstream-kube-rolebinding

# resources -- The resources to request for the Deployment. These are optional
# and are not set by default.
resources:
Expand Down