Implement vault TVL high watermark tracking#619
Merged
vic-Gray merged 1 commit intoJun 29, 2026
Conversation
|
@David-282 is attempting to deploy a commit to the vic's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@David-282 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Vault TVL High Watermark Tracking
closes #508
Summary
This PR implements tracking of each vault's all-time high Total Value Locked (TVL) watermark and exposes it through the API. The watermark is updated only when a vault reaches a new all-time high, ensuring the value is monotonically increasing and can be used as a historical popularity metric.
Changes Made
Database / Entity
tvlAtHighWatermarkfield to theVaultentity.watermarkAchievedAtfield to record when the highest TVL was achieved.Business Logic
VaultsService.deposit()to evaluate the vault's TVL after recalculation.API
Exposed
tvlAtHighWatermarkandwatermarkAchievedAtin:Added
GET /vaults/leaderboard/tvlendpoint to return vaults ranked by their all-time highest TVL.Testing
Updated
VaultFactoryto include the new watermark fields for test data generation.Added/updated service tests to verify:
Acceptance Criteria Checklist
tvlAtHighWatermarkandwatermarkAchievedAt.GET /vaults/leaderboard/tvl.