NABU-1538: clarify Spend vs Supplier Analysis minimum-spend filter#1835
Draft
TedBaileyCodat wants to merge 4 commits into
Draft
NABU-1538: clarify Spend vs Supplier Analysis minimum-spend filter#1835TedBaileyCodat wants to merge 4 commits into
TedBaileyCodat wants to merge 4 commits into
Conversation
The Annual Supplier Minimum Spend threshold only filters the Supplier Analysis tab — Spend Analysis tab totals are calculated across all suppliers. Add a note and tighten the Customer-tab row to set the right expectation when the threshold is non-zero. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| | Company name, Registration #, Tax #, Phone, Addresses, Web links | Administrative details of the customer entity. | Use to identify and verify the customer for compliance purposes. | | ||
| | Start date, End date, Months reviewed | The date range covered by the report. | Source data used in the report is selected based on these dates. <br/> Codat sets these values based on your organization's requirements. | | ||
| | Excludes suppliers with annual spend below | The minimum annual spend threshold that is applied when selecting suppliers for the report. | Suppliers with lower spend are filtered out to focus on meaningful relationships. <br/> Codat sets these values based on your organization's requirements. | | ||
| | Excludes suppliers with annual spend below | The minimum annualized spend threshold applied when selecting suppliers for the **Supplier Analysis** tab. The **Spend Analysis** tab totals are calculated across all suppliers and are not affected by this threshold. | Suppliers with annualized spend below this value are excluded from the Supplier Analysis tab to focus on meaningful relationships. As a result, Spend Analysis _Overall_ totals can exceed the sum of Supplier Analysis rows when the threshold is non-zero. <br/> Codat sets these values based on your organization's requirements. | |
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Google.Passive] In general, use active voice instead of passive voice ('are calculated').
| | Company name, Registration #, Tax #, Phone, Addresses, Web links | Administrative details of the customer entity. | Use to identify and verify the customer for compliance purposes. | | ||
| | Start date, End date, Months reviewed | The date range covered by the report. | Source data used in the report is selected based on these dates. <br/> Codat sets these values based on your organization's requirements. | | ||
| | Excludes suppliers with annual spend below | The minimum annual spend threshold that is applied when selecting suppliers for the report. | Suppliers with lower spend are filtered out to focus on meaningful relationships. <br/> Codat sets these values based on your organization's requirements. | | ||
| | Excludes suppliers with annual spend below | The minimum annualized spend threshold applied when selecting suppliers for the **Supplier Analysis** tab. The **Spend Analysis** tab totals are calculated across all suppliers and are not affected by this threshold. | Suppliers with annualized spend below this value are excluded from the Supplier Analysis tab to focus on meaningful relationships. As a result, Spend Analysis _Overall_ totals can exceed the sum of Supplier Analysis rows when the threshold is non-zero. <br/> Codat sets these values based on your organization's requirements. | |
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Google.Contractions] Use 'aren't' instead of 'are not'.
| | Company name, Registration #, Tax #, Phone, Addresses, Web links | Administrative details of the customer entity. | Use to identify and verify the customer for compliance purposes. | | ||
| | Start date, End date, Months reviewed | The date range covered by the report. | Source data used in the report is selected based on these dates. <br/> Codat sets these values based on your organization's requirements. | | ||
| | Excludes suppliers with annual spend below | The minimum annual spend threshold that is applied when selecting suppliers for the report. | Suppliers with lower spend are filtered out to focus on meaningful relationships. <br/> Codat sets these values based on your organization's requirements. | | ||
| | Excludes suppliers with annual spend below | The minimum annualized spend threshold applied when selecting suppliers for the **Supplier Analysis** tab. The **Spend Analysis** tab totals are calculated across all suppliers and are not affected by this threshold. | Suppliers with annualized spend below this value are excluded from the Supplier Analysis tab to focus on meaningful relationships. As a result, Spend Analysis _Overall_ totals can exceed the sum of Supplier Analysis rows when the threshold is non-zero. <br/> Codat sets these values based on your organization's requirements. | |
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Google.Passive] In general, use active voice instead of passive voice ('are excluded').
| - **Benchmark payment behavior.** Compare the distribution across payment methods over time to track the impact of card enablement efforts. | ||
|
|
||
| :::note Scope of Spend Analysis totals | ||
| The **Spend Analysis** tab aggregates bills, payments, and expenses across **all** suppliers in the reporting period. It is **not** filtered by the _Excludes suppliers with annual spend below_ threshold shown on the Customer tab — that filter only applies to the **Supplier Analysis** tab. When the threshold is non-zero, the Spend Analysis _Overall_ totals will be higher than the sum of the Supplier Analysis supplier rows. |
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Google.Contractions] Use 'it's' instead of 'It is'.
| - **Benchmark payment behavior.** Compare the distribution across payment methods over time to track the impact of card enablement efforts. | ||
|
|
||
| :::note Scope of Spend Analysis totals | ||
| The **Spend Analysis** tab aggregates bills, payments, and expenses across **all** suppliers in the reporting period. It is **not** filtered by the _Excludes suppliers with annual spend below_ threshold shown on the Customer tab — that filter only applies to the **Supplier Analysis** tab. When the threshold is non-zero, the Spend Analysis _Overall_ totals will be higher than the sum of the Supplier Analysis supplier rows. |
There was a problem hiding this comment.
🚫 [vale] reported by reviewdog 🐶
[Google.EmDash] Don't put a space before or after a dash.
| - **Benchmark payment behavior.** Compare the distribution across payment methods over time to track the impact of card enablement efforts. | ||
|
|
||
| :::note Scope of Spend Analysis totals | ||
| The **Spend Analysis** tab aggregates bills, payments, and expenses across **all** suppliers in the reporting period. It is **not** filtered by the _Excludes suppliers with annual spend below_ threshold shown on the Customer tab — that filter only applies to the **Supplier Analysis** tab. When the threshold is non-zero, the Spend Analysis _Overall_ totals will be higher than the sum of the Supplier Analysis supplier rows. |
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Google.Will] Avoid using 'will'.
Shorten the *Excludes suppliers with annual spend below* row so prettier's markdown table check stays green; the detailed Spend vs Supplier divergence already lives in the :::note added under the Spend Analysis tab. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
| | Company name, Registration #, Tax #, Phone, Addresses, Web links | Administrative details of the customer entity. | Use to identify and verify the customer for compliance purposes. | | ||
| | Start date, End date, Months reviewed | The date range covered by the report. | Source data used in the report is selected based on these dates. <br/> Codat sets these values based on your organization's requirements. | | ||
| | Excludes suppliers with annual spend below | The minimum annual spend threshold that is applied when selecting suppliers for the report. | Suppliers with lower spend are filtered out to focus on meaningful relationships. <br/> Codat sets these values based on your organization's requirements. | | ||
| | Excludes suppliers with annual spend below | The minimum supplier spend threshold; applies to the Supplier Analysis tab only. | Suppliers below this threshold are excluded from Supplier Analysis. <br/> Codat sets these values based on your organization's requirements. | |
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Google.Passive] In general, use active voice instead of passive voice ('are excluded').
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
| | Detail | Description | What it tells you | | ||
| | --------------------------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | Company name, Registration #, Tax #, Phone, Addresses, Web links | Administrative details of the customer entity. | Use to identify and verify the customer for compliance purposes. | | ||
| | Start date, End date, Months reviewed | The date range covered by the report. | Source data used in the report is selected based on these dates. <br/> Codat sets these values based on your organization's requirements. | |
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Google.Passive] In general, use active voice instead of passive voice ('is selected').
| | --------------------------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | Company name, Registration #, Tax #, Phone, Addresses, Web links | Administrative details of the customer entity. | Use to identify and verify the customer for compliance purposes. | | ||
| | Start date, End date, Months reviewed | The date range covered by the report. | Source data used in the report is selected based on these dates. <br/> Codat sets these values based on your organization's requirements. | | ||
| | Excludes suppliers with annual spend below | The minimum supplier spend threshold; applies to the Supplier Analysis tab only. | Suppliers below this threshold are excluded from Supplier Analysis. <br/> Codat sets these values based on your organization's requirements. | |
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Google.Passive] In general, use active voice instead of passive voice ('are excluded').
- Rephrase the Insight cell to active voice ("The Supplier Analysis tab
omits suppliers below this threshold")
- Rewrite the :::note to drop passive voice, the "is not"/"non-zero"
constructions, the spaced em-dash, and "will" — keeping the same
meaning
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
| | Detail | Description | What it tells you | | ||
| | --------------------------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | Company name, Registration #, Tax #, Phone, Addresses, Web links | Administrative details of the customer entity. | Use to identify and verify the customer for compliance purposes. | | ||
| | Start date, End date, Months reviewed | The date range covered by the report. | Source data used in the report is selected based on these dates. <br/> Codat sets these values based on your organization's requirements. | |
There was a problem hiding this comment.
📝 [vale] reported by reviewdog 🐶
[Google.Passive] In general, use active voice instead of passive voice ('is selected').
| - **Benchmark payment behavior.** Compare the distribution across payment methods over time to track the impact of card enablement efforts. | ||
|
|
||
| :::note Scope of Spend Analysis totals | ||
| The **Spend Analysis** tab aggregates bills, payments, and expenses across **all** suppliers in the reporting period. The _Excludes suppliers with annual spend below_ threshold on the Customer tab applies only to the **Supplier Analysis** tab. When that threshold is above zero, the Spend Analysis _Overall_ totals exceed the sum of the Supplier Analysis supplier rows. |
There was a problem hiding this comment.
[Google.WordList] Use 'preceding' instead of 'above'.
|
Link check results for preview deployment (https://codat-docs-git-NABU-1538-spend-analysis-minimum-spend-glossary-codat.vercel.app): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:::noteunder the Spend Analysis tab section makes the divergence explicit: when the threshold is non-zero, Spend Analysis Overall totals will exceed the sum of Supplier Analysis supplier rows.Pairs with the glossary update in
reports-generation(NABU-1538-spend-analysis-minimum-spend-glossary).Context
NABU-1538 — Amex (Peacocks) flagged a totals mismatch between the two sheets. Root cause:
AnnualSupplierMinimumSpendis applied to Supplier Analysis only. Decision was to document the behaviour rather than change the report.Test plan
npm run format:mdx:checkagainstdocs/spend-insights/reports/spend-analysis.md(Prettier was not run locally — no node_modules)npm run buildto confirm Docusaurus renders the new:::noteadmonition