fix(lsp): guard Locate against out-of-bounds ranges#196
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix: A bug fix
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
LSPClient.LocateindexesLineCountsby the LSP-provided line numbers and then slicestext[start:end]without validating either. When an LSP server returns a stale or out-of-sync range (for example pylsp/jedi following imports into.venv), the line index can exceedlen(LineCounts)or the offsets can be inverted, producingslice bounds out of range [13:6]and crashing the wholeparserun. This adds bounds and ordering checks that return an error instead of panicking, matching the guard already present in the siblingLinemethod. A unit test covers the valid case and three out-of-bounds variants.zh(optional):
(Optional) Which issue(s) this PR fixes:
Fixes #186
(optional) The PR that updates user documentation: