feat: Add href to action card#4682
Draft
SpyZzey wants to merge 3 commits into
Draft
Conversation
georgylobko
reviewed
Jul 1, 2026
| const wrapper = renderActionCard({ header: 'Header', href: '#test', disabled: true }); | ||
| const anchor = wrapper.getElement().querySelector('a')!; | ||
| expect(anchor).not.toHaveAttribute('href'); | ||
| expect(anchor).toHaveAttribute('aria-disabled', 'true'); |
Member
There was a problem hiding this comment.
I'd suggest to add a check for the button element here
| ) => { | ||
| const baseProps = getBaseProps(rest); | ||
| const buttonRef = useRef<HTMLButtonElement>(null); | ||
| const buttonRef = useRef<HTMLElement>(null); |
Member
There was a problem hiding this comment.
I'd suggest to introduce a more strict type here, like HTMLButtonElement | HTMLAnchorElement and rename the variable to smth like containerRef
| } | ||
|
|
||
| const handleButtonClick = (event: React.MouseEvent<HTMLButtonElement>) => { | ||
| const handleButtonClick = (event: React.MouseEvent<HTMLElement>) => { |
Member
There was a problem hiding this comment.
Same here - more strict type
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4682 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 948 948
Lines 30496 30508 +12
Branches 11155 11160 +5
=======================================
+ Hits 29756 29768 +12
Misses 733 733
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds href to the action card.
Related links, issue #, if available: cvz6736uKl03
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.