Skip to content

(workflows): update rollback context types#6807

Open
vaishnav-mk wants to merge 3 commits into
mainfrom
vaish/workflows-rollback-context-types
Open

(workflows): update rollback context types#6807
vaishnav-mk wants to merge 3 commits into
mainfrom
vaish/workflows-rollback-context-types

Conversation

@vaishnav-mk

Copy link
Copy Markdown
Contributor

Adds ctx: WorkflowStepContext to WorkflowRollbackContext and removes legacy stepName. Updates generated type snapshots and RPC type tests.

@vaishnav-mk vaishnav-mk requested review from a team as code owners June 12, 2026 13:25
@vaishnav-mk vaishnav-mk requested a review from james-elicx June 12, 2026 13:25
@ask-bonk

ask-bonk Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

All snapshots are consistent with the source definition. The changes are straightforward and correct:

  1. stepName: string removed from WorkflowRollbackContext
  2. ctx: WorkflowStepContext added to WorkflowRollbackContext
  3. Generated snapshots updated consistently
  4. Type tests updated to verify the new shape

The WorkflowStepContext type already contains step.name (as part of step: { name: string; count: number }) along with attempt and config, so users still have access to the step name via ctx.step.name - strictly more information than the old stepName string. The type tests cover both overloads of workflowStep.do().

This is a clean, well-scoped type change with no issues.

LGTM

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant