Support GHC 9.14 and semialign >= 1.4#403
Merged
Merged
Conversation
GHC 9.14 moved binding type variables in constructor patterns from TypeApplications to the TypeAbstractions extension, so Rel8.Statement fails to compile with 'Illegal invisible type pattern'. Enable TypeAbstractions there. semialign 1.4 makes Unzip a superclass of Semialign, so the internal 'First' vectorizer newtype needs an Unzip instance. Also widen the base upper bound to < 4.23 to admit base 4.22 (GHC 9.14).
Contributor
|
Thanks! (I'll make a release soon(TM)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there! We're happy users of
rel8in our effect library atelier, thanks for the work you've put into it!While trying to support GHC 9.14 I hit a dependency issue with it so I thought I'd contribute a fix.
The tests passed locally and
nix flake checktoo. I also added a changelog following what was done for 9.12 but let me know if there's anything else I have to do.Closes #402
GHC 9.14 moved binding type variables in constructor patterns from
TypeApplicationsto theTypeAbstractionsextension, soRel8.Statementfails to compile with 'Illegal invisible type pattern'. EnableTypeAbstractionsthere.semialign1.4 makesUnzipa superclass ofSemialign, so the internal 'First' vectorizer newtype needs an Unzip instance.Also widen the base upper bound to < 4.23 to admit base 4.22 (GHC 9.14).