test: move RemoteSigningConfig/RetryConfig field tests to config.rs unit tests#152
Open
memosr wants to merge 3 commits into
Open
test: move RemoteSigningConfig/RetryConfig field tests to config.rs unit tests#152memosr wants to merge 3 commits into
memosr wants to merge 3 commits into
Conversation
Add a Networks section to the README documenting Arc's official chain IDs and the correct wallet configuration for Arc Testnet, with a prominent note that the incorrectly-circulated value 1516 is wrong. Fixes circlefin#94
Document that testnet.arcscan.app and docs.arc.network are the canonical Arc Testnet explorer and docs, and that the dead explorer.testnet.arc.network, explorer.arc.io, and docs.arc.io URLs should not be used. Fixes circlefin#81
…nit tests Relocate config_builder_pattern and retry_config_validation from the integration-gated tests in client.rs into the #[cfg(test)] unit tests in config.rs, where they belong — they only assert field values and need no remote-signer client or gRPC channel. Converted from #[tokio::test] to #[test] since they perform no async work; this also means they now run under plain `cargo test` instead of only with the integration feature. Fixes circlefin#66
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66.
Summary
config_builder_patternandretry_config_validationincrates/remote-signer/src/client.rs(L399-L423)only assert field values for
RemoteSigningConfig/RetryConfig— no clientor gRPC channel involved. This moves them to the
#[cfg(test)]unit tests inconfig.rs, next to the types they exercise.Changes
client.rs(mod integration_tests) toconfig.rs(mod tests).#[tokio::test] async fn→#[test] fn: neither test awaits anything,and the crate's normal test scope has no tokio runtime/macros. Behaviour
(the assertions) is unchanged.
integration-remote-signerfeature; they now run under plaincargo test.Test plan
cargo test -p arc-remote-signer— 9 passed, 0 failed (both moved tests green)cargo check -p arc-remote-signer --tests --features integration-remote-signer— clean