Fix namespace package detection in setup.py#504
Merged
Conversation
Setuptools deprecated the `namespace_packages` option to `setup()`, so it was removed in #500. But `find_packages` then ignores any directories without an `__init__.py` which meant that most of the Cherab files (with the exception of the compiled .so libraries) were left out when producing a wheel. Fix this by replacing `find_packages` with `find_namespace_packages`, which correctly handles PEP420-style namespace packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setuptools deprecated the
namespace_packagesoption tosetup(), so it was removed in #500. Butfind_packagesthen ignores any directories without an__init__.pywhich meant that most of the Cherab files (with the exception of the compiled .so libraries) were left out when producing a wheel.Fix this by replacing
find_packageswithfind_namespace_packages, which correctly handles PEP420-style namespace packages.