📝 Refactor function signatures and improve docstring clarity#502
Merged
jacklovell merged 2 commits intoJul 14, 2026
Merged
Conversation
munechika-koyo
commented
Jun 30, 2026
jacklovell
reviewed
Jul 7, 2026
Member
|
All looks fine to me. If you're happy to add a simple unit test for the error handling in zeeman.pyx then I think it'll be good to merge. |
jacklovell
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor function signatures to enhance consistency and clarity across multiple modules. Key changes include:
Updated function signatures from
cpdeftocdefwhere appropriate.Improved docstring phrasing for better readability.
Corrected parameter type references in docstrings.
Ensured consistency in error messages and return types.