Remove vestigial boxel-ui dist build pipeline#5596
Open
lukemelia wants to merge 1 commit into
Open
Conversation
Host and the boxel-ui test-app consume @cardstack/boxel-ui from source (its exports map resolves ./src/*.gts and ./src/*.css), so the rollup -> dist build and the guards that kept dist fresh are dead code. A fresh checkout builds host directly from boxel-ui's source; nothing compiles or reads dist/ anymore. Remove boxel-ui's rollup pipeline (rollup.config.mjs, the prepack and start:js rollup scripts, the build:js no-op, the rollup devDependencies, and dist from the published files list) and the host-side "ensure boxel-ui dist is fresh" guard (conditional-build.sh, the ensure-boxel-ui script, and its inline invocation in vite-serve.js). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Since
34c836226a"Consume boxel-ui directly", the host and the boxel-ui test-app consume@cardstack/boxel-uifrom source — itsexportsmap resolves./*→./src/*.gtsand./*.css→./src/*.css. Nothing compiles or reads boxel-ui'sdist/anymore, so the rollup →distbuild and the guards that used to keepdistfresh are dead code.This is the followup that commit's message anticipated: "keeps the build scripts but makes them into no-ops… A followup PR can eliminate them. Also, the rollup dependencies and config in boxel-ui could get eliminated."
What's removed
boxel-ui's rollup pipeline (
packages/boxel-ui/addon):rollup.config.mjsprepackandstart:jsrollup scripts, and thebuild:jsno-op (build/startstill run their:typeschildren)rollup,@rollup/plugin-babel, androllup-plugin-copydevDependenciesdistfrom the publishedfileslistThe host-side "ensure boxel-ui dist is fresh" guard (
packages/host):bin/conditional-build.shensure-boxel-uiscript and its inlineexecFileSyncinvocation inscripts/vite-serve.jsRemoving the
vite-serve.jsguard also meanspnpm startno longer runs anember-tscdeclaration build on every launch.Verification
packages/boxel-ui/addon/distdeleted,vite build --mode=developmentinpackages/hostsucceeds (✓ built in ~31s), zero embroider-resolver errors. This is the exact scenario from CS-12187.pnpm --filter @cardstack/boxel-ui buildpasses (nowbuild:typesonly).pnpm-lock.yamldiff is 9 lines, confined to boxel-ui's importer block — only the three rollup deps, no peer re-resolution.Follow-up (needs
workflowOAuth scope)Two comment blocks in
.github/workflows/boxel-cli-publish.ymlstill describe the host build as reading boxel-ui'sdist/(e.g. "the host's vite build imports … which resolves to the addon'sdist/"). Those are now stale — thepnpm --filter @cardstack/boxel-ui buildsteps stay (they builddeclarations/), only the comments need correcting. Left out of this PR because the pushing credential lacksworkflowscope.Context: CS-12187 — triage found the reported lodash/
distembroider error is already resolved onmainby the source-consumption switch; the error only reproduced against a leftover pre-refactordist/. This PR removes the machinery that made it look like a build-ordering bug.🤖 Generated with Claude Code