fix: Add more typecheck fixes for CLI parse#5577
Draft
backspace wants to merge 2 commits into
Draft
Conversation
Card code that imports `@cardstack/runtime-common`, and any card whose `@model.<field>` value type is derived through the `primitive` unique symbol, failed to type-check in a published install: runtime-common is a devDependency npm doesn't install, so the bare specifier was unresolvable and the field-value mapping collapsed to the field class. Generate runtime-common's `.d.ts` into `bundled-types/` (plain emission — no content-tag or `: any` annotation, so the `primitive`/`realmURL` `unique symbol` identities survive) and alias `@cardstack/runtime-common` + `/*` to it in the parse tsconfig. Promotes the plain-glimmer and runtime-common fixtures to the must-pass set; the decorator and positional -helper gaps remain deferred. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The helpers-and-fields fixture called `(formatDateTime @model.when 'MMM D')` — a positional format the helper does not accept: its signature takes the date positionally and options (including `format`) as named args, matching the documented usage and the runtime, which takes an options object. The npm-installed glint correctly rejected the positional shape (the monorepo's leniently allowed it). Use `format='MMM D'` and promote helpers-and-fields to the must-pass set; only the decorator gap remains deferred. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.