fix(android): update sqlcipher-android dependency to version 4.17.0 - #695
Conversation
robingenz
left a comment
There was a problem hiding this comment.
Thanks! Would you be open to creating another PR to pin the iOS version as well, so everything stays consistent?
|
Done, but it turned out to be more than a pin, so flagging why here: #696. Short version: SQLCipher removed CocoaPods support in 4.11.0. From its
So the PR supersedes the pin-only follow-up. It pins both iOS dependency managers (the podspec at the 4.10.0 ceiling, One correction to my own side note above while I am here: I suggested |
Native only. Android SQLCipher 4.17.0 arrives in the base from the upstream merge of capacitor-community#695. iOS is carried from capacitor-community#696, this fork's open follow-up, under the amended native policy: SQLCipher pinned on both dependency managers, Swift Package Manager as the built and verified path, the XCTest target compiling again, the unused CocoaPods development workspace removed, and the plugin's compiler warnings cleared.
Updates
net.zetetic:sqlcipher-androidfrom 4.10.0 to 4.17.0, the latest release on Maven Central. Same shape as #664, which brought it to 4.10.0.Motivation beyond staying current: the iOS side's
SQLCipherpod dependency is unpinned, so fresh iOS installs already resolve to the newest SQLCipher 4.x and its SQLite 3.53 baseline, while Android stays on 4.10's older SQLite. This bump brings the two platforms back to the same SQLite generation.Verified locally on macOS:
cd android && ./gradlew buildsucceeds against 4.17.0, unit tests included.Non-blocking side note: pinning the iOS pod to
~> 4.0would make iOS resolution deterministic within the 4.x line; happy to file that separately if wanted.