fix(examples): derive assemble-examples list from the capability registry (drift guard)#626
Open
blove wants to merge 1 commit into
Open
fix(examples): derive assemble-examples list from the capability registry (drift guard)#626blove wants to merge 1 commit into
blove wants to merge 1 commit into
Conversation
…stry The examples deploy (threadplane-examples) hardcoded which apps to stage, and drifted from the registry — tool-views/json-render/a2ui were added to the registry but never to this list, so they 404'd in production. Derive the staged-example list from the capability registry (the documented single source of truth, already used by the Railway deploy generator) so a new cap can never be silently dropped from the frontend deploy again. Verified: derives all 36 caps incl. the 3 new ag-ui examples; import resolves and the script runs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #619. The production smoke revealed the three new AG-UI examples never deployed — partly because
scripts/assemble-examples.ts(which stages apps into thethreadplane-examplesVercel deploy) hardcoded the capability list and had drifted:tool-views,json-render, anda2uiwere added to the capability registry but never to this list, so their frontends 404'd.This derives the staged list from the capability registry — the documented single source of truth ("Used by serve, build, test, and deploy scripts"), already used by the Railway deploy generator. Now a new cockpit cap is automatically included in the examples deploy; the list can't drift again.
Verified
interrupts, streaming, tool-views, json-render, a2ui.../apps/cockpit/scripts/capability-registryimport resolves; the script runs past list derivation (the build-output guard then fires only because--skip-buildskipped the 36-app build, which production performs first).Not covered here (your infra)
The
threadplane-examplesVercel project's build trigger / Ignored Build Step is a dashboard setting (the repo's rootvercel.jsonbuilds the website, a different project). It didn't rebuild on #619's scripts-only change — so a manual redeploy ofthreadplane-examplesis still needed to publish the 3 frontends; this PR just ensures the contents are correct and drift-proof.🤖 Generated with Claude Code