Fix missing file identity for SENDFILE, MSYNC, MADVISE - #97
Merged
Conversation
do_sendfile() only had raw fds available, but the source fd was never propagated into the event or resolved in userspace, so SENDFILE always reported empty inode/filename. msync/madvise wrote their mapping address into the wrong struct field (offset instead of address), so userspace's address-based mmap-region lookup never fired for either op. - prober.c: capture SENDFILE's source fd in data.fd; fix msync/madvise to store the address in data.address instead of data.offset. - IOTracer.py: resolve SENDFILE via PathResolver.resolve_by_fd(); add a read-only mmap-region lookup (_lookup_region_filename) for MSYNC/MADVISE that doesn't mutate the region cache the way MUNMAP's resolver does, since the mapping stays alive after msync/madvise. - Update VFS_EVENTS.md and schema.py to document the new resolution paths, and correct a pre-existing doc claim that fd was a CSV column (it isn't). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do_sendfile() only had raw fds available, but the source fd was never propagated into the event or resolved in userspace, so SENDFILE always reported empty inode/filename. msync/madvise wrote their mapping address into the wrong struct field (offset instead of address), so userspace's address-based mmap-region lookup never fired for either op.