Avoid f64 precision loss when parsing integer byte counts#171
Open
sayantanmandal1 wants to merge 1 commit into
Open
Avoid f64 precision loss when parsing integer byte counts#171sayantanmandal1 wants to merge 1 commit into
sayantanmandal1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing a byte count with a unit suffix loses precision for large integers,
because the suffixed path in from_str always parses the number as f64:
f64 only has 53 bits of mantissa, so anything at or above 2^53 gets rounded once
a unit is involved. The no-suffix path already parses straight to u64, so it
stays exact.
When the number has no decimal point this parses it as u64 and multiplies by the
unit factor directly. Decimal inputs like "1.5GiB" still go through f64, and
overflow still saturates like before. Added a test for 2^53 + 1.