Adjust pca.R to choose a cluster representative closest to 100M Wasm instructions executed#322
Merged
cfallin merged 1 commit intoJun 25, 2026
Conversation
…m instructions executed Rather than the fewest Wasm instructions executed. 100M was chosen previously as a large enough number to avoid lots of noise and to fill our callgrind-simulated caches, but small enough to run individual iterations relatively quickly.
cfallin
approved these changes
Jun 25, 2026
Member
|
Ah, oops, this repo doesn't have a test-gated merge like Wasmtime does -- I clicked 'merge' expecting it would do so after tests passed. If they don't, now, happy to review followups; sorry about that... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than the fewest Wasm instructions executed. 100M was chosen previously as a large enough number to avoid lots of noise and to fill our callgrind-simulated caches, but small enough to run individual iterations relatively quickly.