Migrate from structopt to clap#320
Merged
Merged
Conversation
Add --help smoke tests for all subcommands, and CLI-level tests for the four previously untested subcommands (effect-size, summarize, clean, validate). Extend benchmark tests to cover flags that had no coverage: --output-file, --name, --engine-flags, --measure, --small-workloads, --pin, --keep-logs, --working-dir. Also fix a TOCTOU race in the clean subcommand where remove_file would fail if a log file disappeared between directory enumeration and removal; NotFound errors are now silently ignored.
Structopt is no longer maintained; the port to use clap with proc-macro derives is fairly straightforward. The tests added in the previous commit provide fairly good coverage for the migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structopt is long deprecated and unmaintained; it's features were rolled into clap's derive functionality, though with a few small differences. I added some additional, basic test coverage and then migrated the cli to use clap.