Skip to content

feat: implement getRandomValues and randomUUID - resolves #213 and #214#215

Open
markhughes wants to merge 1 commit into
browserify:masterfrom
markhughes:feat/213-randomUUID
Open

feat: implement getRandomValues and randomUUID - resolves #213 and #214#215
markhughes wants to merge 1 commit into
browserify:masterfrom
markhughes:feat/213-randomUUID

Conversation

@markhughes

@markhughes markhughes commented May 4, 2022

Copy link
Copy Markdown

@Gambitboy

Copy link
Copy Markdown

Any update on getting this merged or looked at?

@brunomacf

Copy link
Copy Markdown

Any updates? This is important so we can try replace react-native-crypto by crypto-browserify.

@markhughes

markhughes commented Jun 23, 2022

Copy link
Copy Markdown
Author

unsure about the status of crypto-browserify, I think the project is not maintained TBH. Happy to help maintain if current maintainers are inactive?

@3cp

3cp commented Jun 30, 2022

Copy link
Copy Markdown

@markhughes do you want to maintain a fork? I will be one of many who are interested to use.

@Gambitboy

Copy link
Copy Markdown

@jprichardson , @calvinmetcalf , @ForbesLindesay or @fanatid any assistance?

@fanatid

fanatid commented Jul 3, 2022

Copy link
Copy Markdown

Hi, two things:

  • can you move tape update to another PR?
  • is it possible to leave links to node source code for verification that everything is the same?

Thanks!

@eggplantzzz

eggplantzzz commented Jul 14, 2022

Copy link
Copy Markdown

Just stopping by to say I would also be eager to see getRandomValues implemented in this library! Thanks @markhughes!

@markhughes

Copy link
Copy Markdown
Author

Sorry I will fix this PR up later this week, I've been sick and in-out of hospital

@shmillar

Copy link
Copy Markdown

Hello @markhughes , any updates on adding randomUUID() to crypto-browserify?

@BenGu3

BenGu3 commented Feb 17, 2023

Copy link
Copy Markdown

Also curious about when (if 😅) this will be merged in

@markhughes

markhughes commented Feb 20, 2023

Copy link
Copy Markdown
Author

Hi @fanatid sorry for the delay I've been dealing with some health issues!

can you move tape update to another PR?

Got it out of here, thanks. Not sure how that one snuck in but it was required to run on my computer.

is it possible to leave links to node source code for verification that everything is the same?

Perhaps just the specs?

Edit: which matches

@markhughes

Copy link
Copy Markdown
Author

Hey @fanatid, @jprichardson, @calvinmetcalf, @ForbesLindesay, @dcousens - you seem like the more recent past contributors in the browserify package. Could we possibly look at this?

@dcousens dcousens self-assigned this Jul 19, 2023
@jhenriquez

Copy link
Copy Markdown

Any updates? Is there an alternative package anyone is using?

CC: @markhughes @dcousens

@markhughes

Copy link
Copy Markdown
Author

It just needs to be merged. I'm using it for my own projects, but I don't think browserify is maintained like it used to be

@jhenriquez-ax

Copy link
Copy Markdown

Thank you @markhughes, doesn’t seem that anyone is maintaining the library. We forked yours so we can use it indefinitely.

Hopefully someone will take over maintenance here. This library is a recommended webpack 5 polyfill.

@ljharb ljharb mentioned this pull request Nov 25, 2023
@sgtwilko

Copy link
Copy Markdown

Hiya @ljharb any chance this can be reviewed/merged?

Comment thread index.js
return abv
}

exports.randomUUID = function () {

@Vitalii4as Vitalii4as Jun 18, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use randomUUID from browser Crypto API here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in browsers that don’t have it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.