Broken bump release flow#222
Conversation
My bad, I suggested we use this use python instead to edit the Cargo.lock file
a tag could be published and the building job cancelled
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
There was a problem hiding this comment.
I was the one who suggested cargo update --workflow --offline, but didn't know at the time it requires a warm cache since it still resolves all dependencies...
There was a problem hiding this comment.
Comments are badly formatted, see the artifact names in #218 (comment).
There was a problem hiding this comment.
We could push a tag then cancel the build step and have to manually delete the tag.
|
can you quickly explain what was broken and how this PR fixes it? |
|
https://github.com/braintrustdata/bt/actions/workflows/release-bump-pr.yml I think commit e539dd8 is self-explanatory? Comments like #218 (comment) are badly formatted. 60a80b9 and 72e32ce fix potential issues that haven't happened yet. |
https://github.com/braintrustdata/bt/actions/workflows/release-bump-pr.yml
cargo update --workspace --offlinecrashed due to lack of cache, crashing the CI.Replaces it with python.
I think commit e539dd8 is self-explanatory? Comments like #218 (comment) are badly formatted.
60a80b9 and 72e32ce fix potential issues that haven't happened yet.
Prevents having multiple release workflow running at once and publish the tag only after the build has been completed so we don't have empty tags with no associated binaries.