Skip to content

Broken bump release flow#222

Merged
Cedric / ViaDézo1er (viadezo1er) merged 4 commits into
mainfrom
cedric/fix-release-process
Jun 5, 2026
Merged

Broken bump release flow#222
Cedric / ViaDézo1er (viadezo1er) merged 4 commits into
mainfrom
cedric/fix-release-process

Conversation

@viadezo1er

@viadezo1er Cedric / ViaDézo1er (viadezo1er) commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

https://github.com/braintrustdata/bt/actions/workflows/release-bump-pr.yml
cargo update --workspace --offline crashed due to lack of cache, crashing the CI.
Replaces it with python.

I think commit e539dd8 is self-explanatory? Comments like #218 (comment) are badly formatted.

60a80b9 and 72e32ce fix potential issues that haven't happened yet.
Prevents having multiple release workflow running at once and publish the tag only after the build has been completed so we don't have empty tags with no associated binaries.

My bad, I suggested we use this
use python instead to edit the Cargo.lock file
a tag could be published and the building job cancelled
@viadezo1er Cedric / ViaDézo1er (viadezo1er) changed the title Cedric/fix release process Dedicated CI environnement for canary releases Jun 3, 2026
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Latest downloadable build artifacts for this PR commit 72e32ce07391:

Available artifact names
  • artifacts-build-global
  • artifacts-build-local-x86_64-apple-darwin
  • artifacts-build-local-aarch64-pc-windows-msvc
  • artifacts-build-local-x86_64-pc-windows-msvc
  • artifacts-build-local-aarch64-apple-darwin
  • artifacts-build-local-x86_64-unknown-linux-gnu
  • artifacts-build-local-x86_64-unknown-linux-musl
  • artifacts-build-local-aarch64-unknown-linux-gnu
  • artifacts-plan-dist-manifest
  • cargo-dist-cache

@viadezo1er Cedric / ViaDézo1er (viadezo1er) changed the title Dedicated CI environnement for canary releases Broken release flow Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was the one who suggested cargo update --workflow --offline, but didn't know at the time it requires a warm cache since it still resolves all dependencies...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are badly formatted, see the artifact names in #218 (comment).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could push a tag then cancel the build step and have to manually delete the tag.

@lforst

Copy link
Copy Markdown
Member

can you quickly explain what was broken and how this PR fixes it?

@viadezo1er Cedric / ViaDézo1er (viadezo1er) changed the title Broken release flow Broken bump release flow Jun 3, 2026
@viadezo1er

Cedric / ViaDézo1er (viadezo1er) commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

https://github.com/braintrustdata/bt/actions/workflows/release-bump-pr.yml
cargo update --workspace --offline crashed due to lack of cache, crashing the CI.
Replaces it with python to update Cargo.lock.
I think I didn't notice it was broken because I was still bumping the Cargo.toml/lock version field and creating the release PRs manually.

I think commit e539dd8 is self-explanatory? Comments like #218 (comment) are badly formatted.

60a80b9 and 72e32ce fix potential issues that haven't happened yet.
Prevents having multiple release workflow running at once and publish the tag only after the build has been completed so we don't have empty tags with no associated binaries.

@viadezo1er Cedric / ViaDézo1er (viadezo1er) merged commit cc6c959 into main Jun 5, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants