Handle 'auto' return type#16
Open
slburson wants to merge 1 commit into
Open
Conversation
Seems to work in most cases, but for methods of an instantiated template class, it can still give type 'auto'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had previously worked around the use of
autoreturn types by editing the LibTorch headers, but I ran into more cases of them after narrowing the exclusions, and it didn't take long to find this fix that handles most cases. I did still have one instantiated template class with a method withautoreturn type that was still coming out asautoin the bindings, so this doesn't work perfectly, but if seems to be at least a 90% solution.