Handle inherited constructors#23
Open
slburson wants to merge 6 commits into
Open
Conversation
added 4 commits
June 18, 2026 02:49
Squashed commit of the following: commit 80fff37 Author: Scott L. Burson <gyro@reasoning.ai> Date: Thu Jun 18 01:35:48 2026 -0700 Fix various bugs Seems to be working! commit 181c9b5 Author: Scott L. Burson <gyro@reasoning.ai> Date: Mon Jun 15 21:05:55 2026 -0700 Almost working, but still some bugs commit fd886c5 Merge: 4dcff07 4647655 Author: Scott L. Burson <gyro@reasoning.ai> Date: Sat Jun 13 14:22:27 2026 -0700 Merge branch 'master' into inherited-constructors commit 4dcff07 Author: Scott L. Burson <gyro@reasoning.ai> Date: Mon Jun 8 21:07:52 2026 -0700 WIP
This was referenced Jun 18, 2026
added 2 commits
June 21, 2026 15:29
I saw that there were more occurrences of "__claw_this_", so instead of converting them all, I just took out the named constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #20, and should not be merged until that one is. It also depends on PRs with the same title for libresect and cl-resect.
C++'s constructor-inheritance feature is just hell to deal with. Libclang is not as much help as it should be, because inherited constructors do not appear on the subclass's
CXTypeunless they're referenced. (I tried declaring an instance of the subclass, as is done for templates inprepared_header.h, but that didn't cause the constructors to show up.) It is possible to find all the inherited constructors by walking the decl, however, and I figured out how to do this.This allows me to revert the changes I had made to the LibTorch headers that edited out all uses of constructor inheritance.
The generated adapter compiles and loads, and I have spot-checked the differences between the previous results (with constructor inheritance hand-edited out) and the new ones, and they look reasonable.
I ran into a couple more minor bugs in
claw.util:split-template-name-into-groupsandclaw.util:join-groups-into-template-name; I made minor changes to the former and rewrote the latter. I added a few tests intest/util/util.lisp; look there to see what was wrong.